Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1ABF6EB64D7 for ; Fri, 16 Jun 2023 12:23:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 95DA78622D; Fri, 16 Jun 2023 14:23:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="0KgTBTFQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 72A238623A; Fri, 16 Jun 2023 14:23:23 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 26CBB861C1 for ; Fri, 16 Jun 2023 14:23:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=4531059532=patrice.chotard@foss.st.com Received: from pps.filterd (m0288072.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35GBx56b008604; Fri, 16 Jun 2023 14:23:13 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=cjZzUN6dsGtGZrA9wNVpV1usd7csKlq3sYnFgOVb/zs=; b=0KgTBTFQW/eBzU522uvnVv3WVrWq0k/s85Uy84DFXXPW2jQWuZLPKF9A2e/FCu0m8hL/ 9QmAKl6+2vbW5Q2cJwvRfXkc9yLuSf/MLbpKBUOAWrjhyc+evOaFPiA/DP1x9oazx/6l 4y1SrE0ggpF5R62qIgKcjqxLtnPJxCO+7HeDO05hD43oJQrmnYs/y73HKjD148y/Tlqe o05ICqrcdFNS0Qb04Aui+A5cMqw81VQW+Ko+g+kxfgNVcQ0zDG6w2ab88eGYmjWIegSo leToy6ArzdQv8Ku6Kq0Qn0fYafOxqCBcnsf4an25VD36ftHcF+8xUAjesZw/jrh1YRbW dQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3r8m44hjyh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Jun 2023 14:23:13 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 5C04510002A; Fri, 16 Jun 2023 14:23:12 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 36476235F32; Fri, 16 Jun 2023 14:23:12 +0200 (CEST) Received: from [10.252.3.125] (10.252.3.125) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 16 Jun 2023 14:23:11 +0200 Message-ID: <129fa8f9-d828-eef0-2530-e716a0fc4280@foss.st.com> Date: Fri, 16 Jun 2023 14:23:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] ARM: stm32: Use __section(".data") with dot in the section name on DHSOM Content-Language: en-US To: Marek Vasut , CC: Patrick Delaunay , , References: <20230504195208.4941-1-marex@denx.de> <6fa1fdfc-d983-dcb9-7a4c-60055505bc79@foss.st.com> <2d510067-6725-0c84-b672-a0a701ac0fcf@denx.de> From: Patrice CHOTARD In-Reply-To: <2d510067-6725-0c84-b672-a0a701ac0fcf@denx.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.252.3.125] X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-16_08,2023-06-16_01,2023-05-22_02 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 6/16/23 14:18, Marek Vasut wrote: > On 6/16/23 13:46, Patrice CHOTARD wrote: >> >> >> On 5/4/23 21:52, Marek Vasut wrote: >>> The correct specifier of the section is ".data" and not "data", >>> use the former to place the variables in ".data" section. >>> >>> Fixes: 731fd50e27f ("ARM: stm32: Implement board coding on AV96") >>> Fixes: 92ca0f7446c ("ARM: dts: stm32: Synchronize DDR setttings on DH SoMs") >>> Signed-off-by: Marek Vasut >>> --- >>> Cc: Patrice Chotard >>> Cc: Patrick Delaunay >>> Cc: u-boot@dh-electronics.com >>> Cc: uboot-stm32@st-md-mailman.stormreply.com >>> --- >>>   board/dhelectronics/dh_stm32mp1/board.c | 6 +++--- >>>   1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/board/dhelectronics/dh_stm32mp1/board.c b/board/dhelectronics/dh_stm32mp1/board.c >>> index a9a2965a386..a0cdf83ea71 100644 >>> --- a/board/dhelectronics/dh_stm32mp1/board.c >>> +++ b/board/dhelectronics/dh_stm32mp1/board.c >>> @@ -185,9 +185,9 @@ int checkboard(void) >>>   } >>>     #ifdef CONFIG_BOARD_EARLY_INIT_F >>> -static u8 brdcode __section("data"); >>> -static u8 ddr3code __section("data"); >>> -static u8 somcode __section("data"); >>> +static u8 brdcode __section(".data"); >>> +static u8 ddr3code __section(".data"); >>> +static u8 somcode __section(".data"); >>>   static u32 opp_voltage_mv __section(".data"); >>>     static void board_get_coding_straps(void) >> >> Applied to u-boot-stm/next > > Since this is a bugfix, should be for current. Hi Marek Unfortunately the pull request has already sent to the mailing list :-( I will take care next time. Patrice