Received: from eggs.gnu.org ([2001:4830:134:3::10]:54739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5aWi-0001pV-HC for qemu-devel@nongnu.org; Tue, 02 May 2017 12:19:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5aWe-0006zf-J9 for qemu-devel@nongnu.org; Tue, 02 May 2017 12:19:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58492) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d5aWe-0006yg-DQ for qemu-devel@nongnu.org; Tue, 02 May 2017 12:19:44 -0400 References: <1493719600-30853-1-git-send-email-thuth@redhat.com> <52fc3efd-55a7-af2d-ce8c-9b4565dfe6dc@de.ibm.com> <87pofrfgl3.fsf@dusky.pond.sub.org> <93de273c-9a3b-dcb8-dd6e-8b9b4fb09a65@redhat.com> <176d87e9-d899-792f-536e-07cd6f5c7cb6@redhat.com> From: Thomas Huth Message-ID: <12a970d6-591b-5684-8ae0-e043071ced9b@redhat.com> Date: Tue, 2 May 2017 18:19:15 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Markus Armbruster Cc: Christian Borntraeger , qemu-devel@nongnu.org, Vincent Palatin On 02.05.2017 18:08, Paolo Bonzini wrote: [...] >>> So the first lesson should be "no deprecation >>> without documentation" (any reference to 18th century political slogans >>> is purely coincidential :)). >> Would you accept my patch if I'd remove the hunks for vl.c, i.e. a patch >> that just updates the documentation? > > No, updating the documentation is pointless if you don't improve it at > the same time. > > I don't like writing it so often, especially to someone who is a > relatively experienced contributor, but the common word in all these > reviews is "pointless". What is the *purpose* of this work? Marking the -enable-xxx options in the documentation as deprecated would maybe at least prevent that we end up with more -enable-mynewcoolaccelerator options in the future, like we did with -enable-hax now. But ok, I got the message, and I'll shut up here now. Sorry for wasting your time. Thomas