Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2A4CC433EF for ; Fri, 25 Feb 2022 01:24:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236336AbiBYBYr (ORCPT ); Thu, 24 Feb 2022 20:24:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236332AbiBYBYk (ORCPT ); Thu, 24 Feb 2022 20:24:40 -0500 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2074.outbound.protection.outlook.com [40.107.215.74]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EC2D22312F for ; Thu, 24 Feb 2022 17:24:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W4bbaHdOEzQmwa0XaBBG2WSJA1RQ5L/7QrgjogjDdN0gViXLeBduazrqZev5fpKEoX96ZLbdQJRQGgJp3VrF1pcSfBdb2UTFbqj5QZyHWBIH+1P7Z7hZV3qLshEpIOTRTu4rLhmaPwuEh8cqLrz5jrXIkNlgX+wiSL/BCo/rHKy1oC12OIH5sit+FZNMR4iYUlfONgSBzDU73Y9FPXm5QlcsHRTltM5pDaknekcUn+ICxFGX75CE06nZDPN91ecsA5NrwWvAbKQEK5z4m9HkAKFOig6f1KVtxlzktBJE0LXLE0x3pXDkrs0NaYChhFbGiG4UWaBT4pHCAo6pkIKuAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TN2eGYIGUdBWJuWQCufz1iNK8GG8lItzumFv19ugFOU=; b=JeCRK1j29QrqeZjrAOquiqWtYK9Tok5ztsjMSq+AFRwBApTpRsDU6213IuEsKYFCFUj6nzwF9XHmvVxlbvHyBmRc1WtMwFyRN7R3dU95M8FoSwDbuH01BHQraHx7MDWWdNn7MP0W+H8LeWmG9EPxtwNOW/KRKetMSNRP7w+uh40naM7Z1BsNl9MgXJUAO9/Yqq1GB0mik7xVOSufeA73rjI6ycYpzVN1RRqpQi/e5R9dVrFTAN2jdpL+xI/3cHDg/8zYOa85ojFuqm+q8yhsrMuEUlncOyqJJefGAp8jklnAZgMnvkrS8vCf4ImlwzptR91rpzyHwKdemcfwpInFlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oppo.com; dmarc=pass action=none header.from=oppo.com; dkim=pass header.d=oppo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TN2eGYIGUdBWJuWQCufz1iNK8GG8lItzumFv19ugFOU=; b=RlHJp5vfsOxSjOhtGB0T6fsTgtf+dpxlewQp6p8UMO2laP4MUQQf3hA6Ltji9nhvgGL3W1fmgarDyAURCjYPi1s/U2NdMwN8P6zFUaFFMarsEQcN64Q0RHn/TtkBA3Hk3UOlqBpE2SrLSgi8v/p53Y1Nmmj9iCQ1zqH1DounjWE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oppo.com; Received: from TY2PR02MB3165.apcprd02.prod.outlook.com (2603:1096:404:4f::13) by KL1PR02MB4705.apcprd02.prod.outlook.com (2603:1096:820:3b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.25; Fri, 25 Feb 2022 01:24:05 +0000 Received: from TY2PR02MB3165.apcprd02.prod.outlook.com ([fe80::cc04:c674:b67b:baac]) by TY2PR02MB3165.apcprd02.prod.outlook.com ([fe80::cc04:c674:b67b:baac%6]) with mapi id 15.20.5017.024; Fri, 25 Feb 2022 01:24:05 +0000 Message-ID: <12abac3b-1a37-e35d-e0c5-bc86f76b77f3@oppo.com> Date: Fri, 25 Feb 2022 09:24:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [f2fs-dev] [PATCH] common/attr: adbjust acl_max of f2fs Content-Language: en-US To: Sun Ke , fstests@vger.kernel.org, guan@eryu.me Cc: linux-f2fs-devel@lists.sourceforge.net References: <20220208071624.1095904-1-sunke32@huawei.com> From: Chao Yu In-Reply-To: <20220208071624.1095904-1-sunke32@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: HK2PR03CA0050.apcprd03.prod.outlook.com (2603:1096:202:17::20) To TY2PR02MB3165.apcprd02.prod.outlook.com (2603:1096:404:4f::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4680252-2dcb-4acd-6181-08d9f7fd830e X-MS-TrafficTypeDiagnostic: KL1PR02MB4705:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gfwJiI0AkvKk+Fe/z8TZeZch41qLVD9Nkzp7S7FBsY+HnQvRunpJ2deIhu+I1Q7WJwIlbrc+c5+1cZvPATBUQ7pvtR5T7PSqa7HOWvC0G9NHjsNG92xTsOmZk8uc3wWdl3yNFwMlyxh4hRvUDZsBUQlmh+45bh9sk78JbVn+qn9CWIC6RMoe8BJAi9E/rZ8FtaC9tzPmPWrZzkc2L92ErZCdUCwPqdlak5GeJupb7jJ90Bdr9gyVqp5BQ0B9UJX4ICY/ule8w4DhGGHb8PavW2c+A1bnPTuhDtGmB/pJSt+FhkXHmCX2nliZuNhw7WeBYq20IcZtkproo/E2j6eR/5q+VoinMk9PabvfnvuVSGPHVZ3uLdEYGlN9+lo8WZC1m2NfAyWEZ5VwmulAIyNpkrRIsp4TW78sOVlfelFUG66bQ26qiWH3UgUgHqsB1JFcnxYbqCUaBg6Z36gMLmRuhpGoHYTEwprxH0gYM9b3f0FYKzC0BM7y/2BlBk2ioUZm5P3BD9FM3dzlpdsLyJ0MlA+hEGss3t39tJOhtIoJRWyt2MYt8F9yLYS0ajoETMHapfFLaZ8OtJTzdXDj5KUsoGDqZRvmu+llLoG5CMQeu2fXuqeHd6IdRrYiipKqlUV7gxH5QH3vg0lgcpaa/unIbj0I/24Ep+IGDgfopkwgQZV6gJm0qBsWOCErbIqrVCtQOCUNxS1HBAohQNpkihaKbK4adk7SKZRRPisvoCl2Kqy+1a3ibASzmdQ5h+4nyFkgzpka5zWTuqCOhL2vCzjN9Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TY2PR02MB3165.apcprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6506007)(316002)(52116002)(53546011)(8936002)(4744005)(44832011)(26005)(186003)(6512007)(83380400001)(6666004)(5660300002)(38350700002)(38100700002)(2616005)(31686004)(6486002)(66946007)(2906002)(4326008)(8676002)(31696002)(66476007)(66556008)(86362001)(36756003)(508600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVR6emNZQ25HSDFvUmZ0T2hIRmVsMFNGaXcrdmdlQmlFVWExUmxHTENIOU5F?= =?utf-8?B?ZGVUbkFIdkErVHJjQUJUMDBLTXVEUjdURGl3NWFabzZiY3hJU05HbDJwYVZz?= =?utf-8?B?eC9wTXlneTdrVmxSb3MzcVJaOXFIakF1TVlLL3E4NlkvQ3FmdmtzZkJsT1JK?= =?utf-8?B?emlyZHErT0hNbWZxc0NXRm85akloQk9DcThHK2hFY1A3Wldka1JtbTNhUmdR?= =?utf-8?B?NEJGSDZVUHhsdHF0aURzWFlwRmNvV2E1WXgxaDRWMXp5S3ZsMnd1WDRHejhR?= =?utf-8?B?N0FRUkxjMVpVVlZIdkJrZ2RhaGNiNDV6b21uSTc1L29oMktROXlGQVdUMzhz?= =?utf-8?B?eUFOVGFMWCtubWtyeHN3eXBqWTE1cy9BbUhRdUVDcndFTjFwQ2xHWEdSQXZy?= =?utf-8?B?REZwcUdYbE5pRTVldmZCNktISThTbkR1NnA3RVRBZTZsdDNiUlFsNDNnNytD?= =?utf-8?B?bENQK1hTUWhJVnJMbWtLRXBzSWNOZlBPdEVjaEhiY0I1bzhZVU5vcGJQeXBI?= =?utf-8?B?bGlycWpraEIvcitTdUlnWTVMVTJ4Y2VSNHhEL3RkK3VNb1hXbVMrL0VYdHFq?= =?utf-8?B?RUcvUElxSzFSYW5BTWs3d1FYTWc0eXBuQUpTZUNSSWVSYTNwS3BwVHVjYytr?= =?utf-8?B?NTZ4TDJSSnhNbmx5ZlBtY2E1QmJWekFJZ285Z2x6TTRCM3ppZVRHWHVUZ3Zh?= =?utf-8?B?ekNvU1V1Y29jenJHNm82a3dNUk5hMTRRd0RYQ1hOenhNV01pNVlGTjFDLzgr?= =?utf-8?B?WlE2Qm9jSmdZU2hpTjNmUHBsZmVGdjlBNlc2VEFWdWJWRXNnYS9TYkEvUFk3?= =?utf-8?B?WCszdzdBZTltU29kS0k5aHkzNXdQdmMwMHFSdnJ0VVA3cVAxaWs1RkFtdXZR?= =?utf-8?B?TllMUzBCMWY5OFl0SVBqeGhETThTQU4wOUlxOVhpN2dxRVMzMS8wWGZRSjhp?= =?utf-8?B?RGRsSC83VE51cGtDektJUnlJVEtjTExzWVV6OG1NUlJJM1V1MG1vemRsVjhJ?= =?utf-8?B?WWVmMjFLLzB3YVpPWm5yYlZ0NVBlYVplOWpGdm55TlVIcTgvTmQ5SUh3Vi9K?= =?utf-8?B?YldSZkVWRU9Cemc0aUsvaGpSdkJST3kxNWJteUcxY3ZtV2MvZXJ5VTJRTDZM?= =?utf-8?B?cDQ5LzZydlFVNGRJcHFhc2dsVXZlMGRNSTZYdnI0ZlFwZ0tvdU8xWmZBdDZK?= =?utf-8?B?bUZOSmlhdkxiRnN5bWJBdWVWbVdNYUM5d3JhcEFTd3d0a1FhTmZGUkJKU2h0?= =?utf-8?B?cGdZZTZEVDVranQ1Uk5RWVpTMzhYa1VSNVMrVnN4a0dvZXdsSnhJajNkM3di?= =?utf-8?B?TTZMK01zZUVxbVozYm04RVhZampiNVVKdks2SjZoRlBHb3BUazAxTkQ0WTVv?= =?utf-8?B?R2V3MFYrRktpTUFnRUprekh5QTV3QlpsUUt0eVVtVVVrblRnUnc0OGlFZi81?= =?utf-8?B?d3Y3ZHBpYTZiZ0Y1Ty9HbzlPd1p6QjhEOVhkbURGdElHUTd6SUp6bVJoNHgz?= =?utf-8?B?QWxpNUJRTC9kL2g2cDdSRkFWMFIrSUdSQ1l5QUJkWVV2VURvdmhYV216bkYr?= =?utf-8?B?MDk5a0l2MXp1SUdVUDh3cTF4YXQ4RHZjY1ZuaWxPT1Rjck8rWDFsdERINW9o?= =?utf-8?B?K3hzK1FQaDgrU09GMXZQQVhBY0hFS1k0WEh3OE10NEpzK25YaWlrcFBGMHJY?= =?utf-8?B?VnNWOWdkcGh1OWZmaWhtcVljeG0zV1J1ZUkwQXh2cWFVSnU4YXJiaktKVkt3?= =?utf-8?B?S05zZlRFN3B0VmtQRHM4SGwrbVNyd1ZkbGtlayszM2x2cUdxNlR2OFg3cU9V?= =?utf-8?B?aGxsVzlPWTdXMWNUOWgyS0VHN0MzU1lZK2hYai9UZ0cwWFZGMHlTeHBpT0sw?= =?utf-8?B?SVpsVGtOb0gyVHduYVg1dnNMQmNBazZSalZQQ3dBdi83Qnh2d2ttY3crV3Nt?= =?utf-8?B?MWZ5ODRlWXU2dm8zb0c0VjdpVlpKZHppaEQySjhmWVNJUEh5bllDMlN5TC9E?= =?utf-8?B?TTIzdnhnQWQ5MDBQdXYzdEJhSEIweGZFL3JheDFRdC91RzlxZWRwc3J1ZmNS?= =?utf-8?B?ZnR5M1NpNG1Ma3lZbkVwVjlhMlUycVR4blFtN1ZVQWZhd1VLUmFiMjdYeTRu?= =?utf-8?B?c2xIZUNwV09FYUFhaTJESEg4NENTZmNFWFdlR0hZUlBSNU9KSEZGWjBiWkpF?= =?utf-8?Q?f2kk8NPGh8KSkcFtzXUkvWo=3D?= X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4680252-2dcb-4acd-6181-08d9f7fd830e X-MS-Exchange-CrossTenant-AuthSource: TY2PR02MB3165.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 01:24:05.1867 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YgIo8sS9yVs4PcmPkEHNzG1Eju1q8YADQD/CizbYxyBg4fkHkzeCArgkuRZ3tym3UMb10ag+zxWVQxiZ5/4NIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR02MB4705 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On 2022/2/8 15:16, Sun Ke via Linux-f2fs-devel wrote: > f2fs has set inline_xattr as a default option, and introduced a new > option named 'noinline_xattr' for disabling default inline_xattr option. > So in _acl_get_max we need to check 'noinline_xattr' string in fs > option, otherwise we may select the wrong max acl number since we always > found the string 'inline_xattr' in fs option. > > Additionally, f2fs has changed disk layout of xattr block a bit, so will > contain one more entry in both inline and noinline xattr inode, this > patch will modify the max acl number to adjust it. > > Suggested-by: Chao Yu > Signed-off-by: Sun Ke Reviewed-by: Chao Yu Thanks,