References: <20180120164114.12478-1-steffan@...1856...> <20180126105803.26646-1-steffan@...1856...> From: Steffan Karger Message-ID: <12ec1e85-3ded-86e3-002b-bd98ec2c8372@...1856...> Date: Thu, 1 Feb 2018 07:34:44 +0100 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [Openvpn-devel] [PATCH v2] Enable stricter compiler warnings by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Selva Nair Cc: openvpn-devel Hi, On 27-01-18 17:47, Selva Nair wrote: > As this is added by default (not in response to --enable/--disable > directives), may be better to prepend to user's CFLAGS? I'm not sure > what the standard practice is, though.. Considering the complexity of > configury, preserving user's input is hard, so may be ok like this. Good point. I'll send a v3 with CFLAGS last (for default flags). > Just one thing: if we support compilers other than gcc/clang (say, > xlc) this would need a test like AX_CHECK_COMPILE_FLAG(). Hm, I don't think we do for configure.ac. We do sort-of support MSVC, but that doesn't use this build system. Gert, David, any opinions? -Steffan