Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D460A29 for ; Mon, 18 Apr 2022 17:22:49 +0000 (UTC) Received: by mail-ej1-f50.google.com with SMTP id bv19so28040505ejb.6 for ; Mon, 18 Apr 2022 10:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FXb8JTv6xgqQWntZiQXAcxcRjbYBTKiyAa3H17w50Tc=; b=RVUSTxRF71mSooXE7dW+1t+mrhTmjHAHT5FUH1id48JJYRdzMBRa5XLtYjyTbab6pH xtz9QHPlqZY7utKycL3xrmT/Z+/LXdB1ybCh1bLHcoFwghGk8FDSVQ/P4uaPjaZkc7HE KRGCzINwviScy2NdVrYJY5OB8vwNTqYa+c9s+U+vkJXJZNdgU/O7FTzPVsV8tbvhGMd8 Xalc+DB8fo6yg8KPaE82bG6ax5KakTDI/JMD5Sfk7YnFV15PePUvvTATXqxinPq98Aw3 /duHjrsQqxsoDdjIs2TjMBmqJOsr/uyUDA3aiNTlLlwQN00F5TS8iTs7Ar7sGJe3WXkU Sw0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FXb8JTv6xgqQWntZiQXAcxcRjbYBTKiyAa3H17w50Tc=; b=NEWfS29Now0tuIQZAprdwCaUDBZ3bADNJERRUr9OijWIDqGrdE7vKoa76tzpztWNxT 5rNpkLpNu0sHvWkyfxrniULVQmESOcjBKqSDR67wLrOrQQvN6oOn/s8iXgta7rGWPZOk D/pSeTd2CQ9h2B3cUhoZ69Dc65GslyAHCJawINFiyQl0HzAWzYpJkFEwbAgtnBJYk95T /bmQ4Ibd10YiXRXqknb8M7hXQIjr4dmyiBEjMBCQUY+r63fs2d0BqPOKSTE0obPNzirO Wg3qTQGF+lbBp6xY172U9N4/hq8ytiXdGoG3uQwZ4tuAV8ExcjoM8vWLZIXM3K8SzjBC xIvA== X-Gm-Message-State: AOAM530HfD7fXxFSbs3W5gkclNp4/a+02LXi0+mJn+3oCaJaae82k9+U 7LmRNJgcG8tE7wuqdV2IrHw= X-Google-Smtp-Source: ABdhPJy/4R8YV8uUl1wOhx2cVpZcruXMe+ePdvRcORn0HBg6sx9nPwNqsCK2rl4qxRsItMqkwCVj5w== X-Received: by 2002:a17:907:a421:b0:6ea:beb6:fd99 with SMTP id sg33-20020a170907a42100b006eabeb6fd99mr10088740ejc.261.1650302567563; Mon, 18 Apr 2022 10:22:47 -0700 (PDT) Received: from leap.localnet (host-79-50-86-254.retail.telecomitalia.it. [79.50.86.254]) by smtp.gmail.com with ESMTPSA id r3-20020aa7cb83000000b0041b573e2654sm7222087edt.94.2022.04.18.10.22.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 10:22:46 -0700 (PDT) From: "Fabio M. De Francesco" To: Mike Rapoport Cc: Ira Weiny , Andrew Morton , Catalin Marinas , "Matthew Wilcox (Oracle)" , Will Deacon , Peter Collingbourne , Vlastimil Babka , Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH] mm/highmem: Fix kernel-doc warnings in highmem*.h Date: Mon, 18 Apr 2022 19:22:44 +0200 Message-ID: <13023135.uLZWGnKmhe@leap> In-Reply-To: References: <20220418075304.20259-1-fmdefrancesco@gmail.com> Precedence: bulk X-Mailing-List: outreachy@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On luned=C3=AC 18 aprile 2022 16:43:05 CEST Mike Rapoport wrote: > Hi, >=20 > On Mon, Apr 18, 2022 at 09:53:04AM +0200, Fabio M. De Francesco wrote: > > `scripts/kernel-doc -none include/linux/highmem*` reports the following > > warnings: > >=20 > > include/linux/highmem.h:160: warning: expecting prototype for=20 kunmap_atomic(). Prototype was for nr_free_highpages() instead > > include/linux/highmem-internal.h:256: warning: Function parameter or=20 member '__addr' not described in 'kunmap_atomic' > > include/linux/highmem-internal.h:256: warning: Excess function=20 parameter 'addr' description in 'kunmap_atomic' > >=20 > > Fix these warnings by (1) move the kernel-doc comments from highmem.h=20 to > > highmem-internal.h (which is the file were the kunmap_atomic() macro is > > actually defined), merge it with the comment which already was in >=20 > ^ (2) ? >=20 > > highmem-internal.h, and (3) replace "@addr" with "@__addr". Hi Mike, It looks like these days I'm a bit distracted... I'm about to send a v2 patch. >=20 > There is also replacement of "addr" with "page", so I'd phrase (3) as > "use correct parameter names" Yes, correct, I missed this too :( > =20 > > Signed-off-by: Fabio M. De Francesco >=20 > Other than that >=20 > Acked-by: Mike Rapoport Thanks for your "Acked-by:" tag. Regards, =46abio > > --- > > include/linux/highmem-internal.h | 14 +++++++++++--- > > include/linux/highmem.h | 13 +------------ > > 2 files changed, 12 insertions(+), 15 deletions(-) > >=20 > > [snip]