References: <1486364115-9801-1-git-send-email-chipitsine@...277...> <20170206104444.12662-1-davids@...515...> From: =?UTF-8?Q?Samuli_Sepp=c3=a4nen?= Message-ID: <13044f0c-953c-af95-79dc-d7b641ae6573@...515...> Date: Tue, 7 Feb 2017 11:06:11 +0200 MIME-Version: 1.0 In-Reply-To: <20170206104444.12662-1-davids@...515...> Subject: Re: [Openvpn-devel] [PATCH applied] github: Add PR template with contributor related information List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: quoted-printable To: David Sommerseth , chipitsine@...277... Cc: openvpn-devel@lists.sourceforge.net On 06/02/2017 12:44, David Sommerseth wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > I have ACKed and applied this, just to get this one resolved. But I am v= ery > disappointed that you have yet again completely ignored the guidelines > described in the URL[1] already provided to you - which describes how a p= atch > and commit message should look like. > > In fact - your SUBJECT line was 167 characters long, _including_ a URL. = It > did not even have a proper body message. *sigh* The 80 character limit is only documented here: This is a fairly new page and not linked to from anywhere. On top of=20 that the page says that "This coding style is not final and not yet in=20 effect." Moreover, our developer documentation is quite a mess right now: For example, the DeveloperDocumentation page links to here: That page is a stub with very little and possibly outdated/false=20 information. Then we have which says we use "GNU coding style". And then we have the actual 2.4=20 code style instructions here: There is a fairly well-hidden link on the DeveloperDocumentation page to=20 these Git commit message instructions: I think that blog posting is too verbose. The essential information,=20 such as the "seven rules" you linked to should be directly on the=20 DeveloperDocumentation page, with links to the original documents. I don't want to argue whether Ilya should know the 80 character limit or=20 not. But how can we expect _new_ developers to get our rules if they are=20 not documented properly or if documentation is contradictory? Or if the=20 documentation is hidden as well as the CodeStyle page? I will create a copy of the DeveloperDocumentation page and clean that=20 one up. Then I will send a link so that others can have a look. --=20 Samuli Sepp=E4nen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock