Received: from mail.pbcl.net ([88.198.119.4] helo=hetzner.pbcl.net) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1QLyBe-0008FE-WA for openembedded-devel@lists.openembedded.org; Mon, 16 May 2011 15:50:19 +0200 Received: from cambridge.roku.com ([81.142.160.137] helo=[172.30.1.145]) by hetzner.pbcl.net with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1QLxjk-00040r-1f; Mon, 16 May 2011 15:21:29 +0200 From: Phil Blundell To: openembedded-devel@lists.openembedded.org In-Reply-To: <1305553187-25173-1-git-send-email-otavio@ossystems.com.br> References: <1305553187-25173-1-git-send-email-otavio@ossystems.com.br> Date: Mon, 16 May 2011 14:47:17 +0100 Message-ID: <1305553637.2429.35.camel@phil-desktop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Cc: Otavio Salvador Subject: Re: [meta-oe][PATCH v2] libpcsclite: add version 1.7.2 X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2011 13:50:19 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Mon, 2011-05-16 at 13:39 +0000, Otavio Salvador wrote: > + # handle vars values > + sed -i 's,/usr/sbin,${sbindir},g' "${D}/${sysconfdir}/init.d/pcscd" It looks like you also need to do /var -> ${localstatedir}. Other than that, I think this is basically okay; it'll blow up if ${sbindir} happens to contain a comma, but that is probably no worse than any number of other similar constructs that we already have in the repository. p.