Received: from mail.gw90.de ([188.40.100.199]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1QPEjC-0004uX-0t for openembedded-devel@lists.openembedded.org; Wed, 25 May 2011 16:06:26 +0200 Received: from f053034074.adsl.alicedsl.de ([78.53.34.74] helo=[192.168.178.21]) by mail.gw90.de with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1QPEga-00068J-Qg for openembedded-devel@lists.openembedded.org; Wed, 25 May 2011 14:03:45 +0000 From: Paul Menzel To: openembedded-devel@lists.openembedded.org In-Reply-To: <4DDD05E0.4070504@opendreambox.org> References: <1306328337-19285-1-git-send-email-eyalr@ti.com> <4DDD05E0.4070504@opendreambox.org> Date: Wed, 25 May 2011 16:03:24 +0200 Message-ID: <1306332204.10056.81.camel@mattotaupa> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 Subject: Re: [PATCH] wpa-gui-e: build the latest version from git sources X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2011 14:06:26 -0000 X-Groupsio-MsgNum: 32285 Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-BJwNNoiCpWHftVgNmp/V" --=-BJwNNoiCpWHftVgNmp/V Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dear Andreas, dear Eyal, On Mi, 2011-05-25 at 15:36 +0200, Andreas Oberritter wrote: > On 05/25/2011 02:58 PM, Eyal Reizer wrote: [=E2=80=A6] > > +SRCREV =3D "b8fb017272ed4794339978c9fbc0e74571a44728" > > +PR =3D "r0" >=20 > PR =3D "r0" is the default and can be removed. it seems there are different opinions on this topic. At least the manual says differently. Note =20 It is good practice to always define PR in your recipes, even for the "r0" release, so that when editing the recipe it is clear that the PR number needs to be updated. =20 You should always increment PR when modifying a recipe. Sometimes this can be avoided if the change will have no effect on the actual packages generated by the recipe, such as updating the SRC_URI to point to a new host. If in any doubt then you should increase the PR regardless of what has been changed. =20 The PR value should never be decremented. If you accidentally submit a large PR value for example then it should be left at the value and just increased for new releases, not reset back to a lower version. > > +PV =3D "0.7.3+0.8.0-rc" > > +PR_append =3D "+gitr${SRCPV}" >=20 > SRCPV should not be used in PR (even if it's been copied from another > recipe which does it wrong). I am still confused about this one. That is why I still have not committed the pkg-config patch yet [2]. Could the right way be documented in the manual. [=E2=80=A6] Thanks, Paul [1] http://docs.openembedded.org/usermanual/usermanual.html#recipes_version= ing [2] http://patches.openembedded.org/patch/2711/ --=-BJwNNoiCpWHftVgNmp/V Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAk3dDCwACgkQPX1aK2wOHVjFRQCfSTkmeIoIKV6Zan5sBzBCA3+l KMQAn1/A0rN2lD1zEXqXF94O7YyC0mnu =GkVB -----END PGP SIGNATURE----- --=-BJwNNoiCpWHftVgNmp/V--