From: Michel =?ISO-8859-1?Q?D=E4nzer?= Subject: Re: [BUG] drm/radeon: locking problems with page_flip Date: Tue, 13 Sep 2011 11:29:12 +0200 Message-ID: <1315906152.17617.24.camel@thor.local> References: <20110913034955.GJ23706@smp.if.uj.edu.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20110913034955.GJ23706@smp.if.uj.edu.pl> Sender: linux-kernel-owner@vger.kernel.org To: Witold Baryluk Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Die, 2011-09-13 at 05:49 +0200, Witold Baryluk wrote:=20 >=20 > I yeasterday discovered pretty nasty issue in radeon / drm code, > and page_flip locking code on my ThinkPad T43. Does the patch below fix the problem? =46rom ed7cf809c4fb737fa486b24004ee47056bf0e797 Mon Sep 17 00:00:00 200= 1 =46rom: =3D?UTF-8?q?Michel=3D20D=3DC3=3DA4nzer?=3D Date: Thu, 8 Sep 2011 17:36:22 +0200 Subject: [PATCH] drm/radeon: Unreference GEM object outside of spinlock in page flip error path. MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Should fix https://bugzilla.redhat.com/show_bug.cgi?id=3D726277 . Signed-off-by: Michel D=C3=A4nzer --- drivers/gpu/drm/radeon/radeon_display.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/= radeon/radeon_display.c index 6cc17fb..6adb3e5 100644 --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -473,8 +473,8 @@ pflip_cleanup: spin_lock_irqsave(&dev->event_lock, flags); radeon_crtc->unpin_work =3D NULL; unlock_free: - drm_gem_object_unreference_unlocked(old_radeon_fb->obj); spin_unlock_irqrestore(&dev->event_lock, flags); + drm_gem_object_unreference_unlocked(old_radeon_fb->obj); radeon_fence_unref(&work->fence); kfree(work); =20 --=20 1.7.5.4 --=20 Earthling Michel D=C3=A4nzer | http://www.a= md.com Libre software enthusiast | Debian, X and DRI develope= r