From: przanoni@gmail.com Subject: [PATCH 1/2] Fix "always false" conditionals Date: Fri, 16 Sep 2011 18:53:01 -0300 Message-ID: <1316209981-23217-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-f49.google.com (mail-yw0-f49.google.com [209.85.213.49]) by gabe.freedesktop.org (Postfix) with ESMTP id B92C29E83E for ; Fri, 16 Sep 2011 14:53:29 -0700 (PDT) Received: by ywf9 with SMTP id 9so3696081ywf.36 for ; Fri, 16 Sep 2011 14:53:29 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org RnJvbTogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+CgpFbnVtcyBhcmUg dW5zaWduZWQgYnkgZGVmYXVsdCBpbiBnY2MgYW5kIHdlIGNhbid0IHJlbHkgb24gYW55IHNwZWNp ZmljCnNpZ25lZGVzcyBmb3IgdGhlIG90aGVyIGNvbXBpbGVycy4KCmk5NjVfcmVuZGVyLmM6IElu IGZ1bmN0aW9uIOKAmGk5NjVfcHJlcGFyZV9jb21wb3NpdGXigJk6Cmk5NjVfcmVuZGVyLmM6MjAx ODoyOiB3YXJuaW5nOiBjb21wYXJpc29uIG9mIHVuc2lnbmVkIGV4cHJlc3Npb24gPCAwIGlzIGFs d2F5cyBmYWxzZQppOTY1X3JlbmRlci5jOjIwMjU6Mjogd2FybmluZzogY29tcGFyaXNvbiBvZiB1 bnNpZ25lZCBleHByZXNzaW9uIDwgMCBpcyBhbHdheXMgZmFsc2UKaTk2NV9yZW5kZXIuYzoyMDUw OjM6IHdhcm5pbmc6IGNvbXBhcmlzb24gb2YgdW5zaWduZWQgZXhwcmVzc2lvbiA8IDAgaXMgYWx3 YXlzIGZhbHNlCmk5NjVfcmVuZGVyLmM6MjA1NzozOiB3YXJuaW5nOiBjb21wYXJpc29uIG9mIHVu c2lnbmVkIGV4cHJlc3Npb24gPCAwIGlzIGFsd2F5cyBmYWxzZQoKU2lnbmVkLW9mZi1ieTogUGF1 bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+Ci0tLQogc3JjL2k5NjVfcmVuZGVy LmMgfCAgIDE4ICsrKysrKysrKystLS0tLS0tLQogMSBmaWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRp b25zKCspLCA4IGRlbGV0aW9ucygtKQoKSSBjb3VsZCBhbHNvIGhhdmUgZGVmaW5lZCBGSUxURVJf RVJST1IgYXMgLTEsIHRoZW4gZ2NjIHdvdWxkIGhhdmUgYXV0b21hZ2ljYWxseQpjb252ZXJ0ZWQg dGhlIGVudW0gdG8gc2lnbmVkLCBidXQgSSdtIG5vdCBzdXJlIHdoYXQgb3RoZXIgY29tcGlsZXJz IHdvdWxkIGRvIGluCnRoaXMgY2FzZS4KCmRpZmYgLS1naXQgYS9zcmMvaTk2NV9yZW5kZXIuYyBi L3NyYy9pOTY1X3JlbmRlci5jCmluZGV4IDdlMWRhNWIuLjJiZDI1YjUgMTAwNjQ0Ci0tLSBhL3Ny Yy9pOTY1X3JlbmRlci5jCisrKyBiL3NyYy9pOTY1X3JlbmRlci5jCkBAIC02MDYsNyArNjA2LDgg QEAgc3RhdGljIGNvbnN0IHVpbnQzMl90IHBzX2tlcm5lbF9tYXNrbm9jYV9wcm9qZWN0aXZlX3N0 YXRpY19nZW43W11bNF0gPSB7CiB0eXBlZGVmIGVudW0gewogCVNBTVBMRVJfU1RBVEVfRklMVEVS X05FQVJFU1QsCiAJU0FNUExFUl9TVEFURV9GSUxURVJfQklMSU5FQVIsCi0JRklMVEVSX0NPVU5U CisJRklMVEVSX0NPVU5ULAorCUZJTFRFUl9FUlJPUgogfSBzYW1wbGVyX3N0YXRlX2ZpbHRlcl90 OwogCiB0eXBlZGVmIGVudW0gewpAQCAtNjE0LDcgKzYxNSw4IEBAIHR5cGVkZWYgZW51bSB7CiAJ U0FNUExFUl9TVEFURV9FWFRFTkRfUkVQRUFULAogCVNBTVBMRVJfU1RBVEVfRVhURU5EX1BBRCwK IAlTQU1QTEVSX1NUQVRFX0VYVEVORF9SRUZMRUNULAotCUVYVEVORF9DT1VOVAorCUVYVEVORF9D T1VOVCwKKwlFWFRFTkRfRVJST1IKIH0gc2FtcGxlcl9zdGF0ZV9leHRlbmRfdDsKIAogdHlwZWRl ZiBlbnVtIHsKQEAgLTEyNDgsNyArMTI1MCw3IEBAIHN0YXRpYyBzYW1wbGVyX3N0YXRlX2ZpbHRl cl90IHNhbXBsZXJfc3RhdGVfZmlsdGVyX2Zyb21fcGljdHVyZShpbnQgZmlsdGVyKQogCWNhc2Ug UGljdEZpbHRlckJpbGluZWFyOgogCQlyZXR1cm4gU0FNUExFUl9TVEFURV9GSUxURVJfQklMSU5F QVI7CiAJZGVmYXVsdDoKLQkJcmV0dXJuIC0xOworCQlyZXR1cm4gRklMVEVSX0VSUk9SOwogCX0K IH0KIApAQCAtMTI2NCw3ICsxMjY2LDcgQEAgc3RhdGljIHNhbXBsZXJfc3RhdGVfZXh0ZW5kX3Qg c2FtcGxlcl9zdGF0ZV9leHRlbmRfZnJvbV9waWN0dXJlKGludCByZXBlYXRfdHlwZSkKIAljYXNl IFJlcGVhdFJlZmxlY3Q6CiAJCXJldHVybiBTQU1QTEVSX1NUQVRFX0VYVEVORF9SRUZMRUNUOwog CWRlZmF1bHQ6Ci0JCXJldHVybiAtMTsKKwkJcmV0dXJuIEVYVEVORF9FUlJPUjsKIAl9CiB9CiAK QEAgLTIwMTUsMTQgKzIwMTcsMTQgQEAgaTk2NV9wcmVwYXJlX2NvbXBvc2l0ZShpbnQgb3AsIFBp Y3R1cmVQdHIgc291cmNlX3BpY3R1cmUsCiAKIAljb21wb3NpdGVfb3AtPnNyY19maWx0ZXIgPQog CSAgICBzYW1wbGVyX3N0YXRlX2ZpbHRlcl9mcm9tX3BpY3R1cmUoc291cmNlX3BpY3R1cmUtPmZp bHRlcik7Ci0JaWYgKGNvbXBvc2l0ZV9vcC0+c3JjX2ZpbHRlciA8IDApIHsKKwlpZiAoY29tcG9z aXRlX29wLT5zcmNfZmlsdGVyID09IEZJTFRFUl9FUlJPUikgewogCQlpbnRlbF9kZWJ1Z19mYWxs YmFjayhzY3JuLCAiQmFkIHNyYyBmaWx0ZXIgMHgleFxuIiwKIAkJCQkgICAgIHNvdXJjZV9waWN0 dXJlLT5maWx0ZXIpOwogCQlyZXR1cm4gRkFMU0U7CiAJfQogCWNvbXBvc2l0ZV9vcC0+c3JjX2V4 dGVuZCA9CiAJICAgIHNhbXBsZXJfc3RhdGVfZXh0ZW5kX2Zyb21fcGljdHVyZShzb3VyY2VfcGlj dHVyZS0+cmVwZWF0VHlwZSk7Ci0JaWYgKGNvbXBvc2l0ZV9vcC0+c3JjX2V4dGVuZCA8IDApIHsK KwlpZiAoY29tcG9zaXRlX29wLT5zcmNfZXh0ZW5kID09IEVYVEVORF9FUlJPUikgewogCQlpbnRl bF9kZWJ1Z19mYWxsYmFjayhzY3JuLCAiQmFkIHNyYyByZXBlYXQgMHgleFxuIiwKIAkJCQkgICAg IHNvdXJjZV9waWN0dXJlLT5yZXBlYXRUeXBlKTsKIAkJcmV0dXJuIEZBTFNFOwpAQCAtMjA0Nywx NCArMjA0OSwxNCBAQCBpOTY1X3ByZXBhcmVfY29tcG9zaXRlKGludCBvcCwgUGljdHVyZVB0ciBz b3VyY2VfcGljdHVyZSwKIAogCQljb21wb3NpdGVfb3AtPm1hc2tfZmlsdGVyID0KIAkJICAgIHNh bXBsZXJfc3RhdGVfZmlsdGVyX2Zyb21fcGljdHVyZShtYXNrX3BpY3R1cmUtPmZpbHRlcik7Ci0J CWlmIChjb21wb3NpdGVfb3AtPm1hc2tfZmlsdGVyIDwgMCkgeworCQlpZiAoY29tcG9zaXRlX29w LT5tYXNrX2ZpbHRlciA9PSBGSUxURVJfRVJST1IpIHsKIAkJCWludGVsX2RlYnVnX2ZhbGxiYWNr KHNjcm4sICJCYWQgbWFzayBmaWx0ZXIgMHgleFxuIiwKIAkJCQkJICAgICBtYXNrX3BpY3R1cmUt PmZpbHRlcik7CiAJCQlyZXR1cm4gRkFMU0U7CiAJCX0KIAkJY29tcG9zaXRlX29wLT5tYXNrX2V4 dGVuZCA9CiAJCSAgICBzYW1wbGVyX3N0YXRlX2V4dGVuZF9mcm9tX3BpY3R1cmUobWFza19waWN0 dXJlLT5yZXBlYXRUeXBlKTsKLQkJaWYgKGNvbXBvc2l0ZV9vcC0+bWFza19leHRlbmQgPCAwKSB7 CisJCWlmIChjb21wb3NpdGVfb3AtPm1hc2tfZXh0ZW5kID09IEVYVEVORF9FUlJPUikgewogCQkJ aW50ZWxfZGVidWdfZmFsbGJhY2soc2NybiwgIkJhZCBtYXNrIHJlcGVhdCAweCV4XG4iLAogCQkJ CQkgICAgIG1hc2tfcGljdHVyZS0+cmVwZWF0VHlwZSk7CiAJCQlyZXR1cm4gRkFMU0U7Ci0tIAox LjcuNC4xCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=