From: Jan Glauber <jang@linux.vnet.ibm.com>
Subject: Re: [PATCH RFC 7/8] s390/jump-label: add
 arch_jump_label_transform_early()
Date: Fri, 30 Sep 2011 16:48:19 +0200
Message-ID: <1317394099.11297.54.camel@localhost.localdomain>
References: <cover.1317338254.git.jeremy.fitzhardinge@citrix.com>
	 <b1d87557dc3001031ee8d7f69ee97b90cecba6aa.1317338254.git.jeremy.fitzhardinge@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <b1d87557dc3001031ee8d7f69ee97b90cecba6aa.1317338254.git.jeremy.fitzhardinge@citrix.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Steven Rostedt <rostedt@goodmis.org>, "David S. Miller" <davem@davemloft.net>, David Daney <david.daney@cavium.com>, Michael Ellerman <michael@ellerman.id.au>, Jason Baron <jbaron@redhat.com>, the arch/x86 maintainers <x86@kernel.org>, Xen Devel <xen-devel@lists.xensource.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2011-09-29 at 16:26 -0700, Jeremy Fitzhardinge wrote:
> From: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
>=20
> This allows jump-label entries to be modified early, in a pre-SMP
> environment.
>=20
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> Cc: Jan Glauber <jang@linux.vnet.ibm.com>

Hi Jeremy,

Your patch looks fine, if you can fix the minor compiler warnings
below. Excluding stop_machine() on pre-SMP also looks safer too me.

--Jan

  CC      arch/s390/kernel/jump_label.o
arch/s390/kernel/jump_label.c: In function =E2=80=98__jump_label_transf=
orm=E2=80=99:
arch/s390/kernel/jump_label.c:41:2: error: =E2=80=98rc=E2=80=99 undecla=
red (first use in this function)
arch/s390/kernel/jump_label.c:41:2: note: each undeclared identifier is=
 reported only once for each function it appears in
arch/s390/kernel/jump_label.c:41:2: warning: passing argument 1 of =E2=80=
=98probe_kernel_write=E2=80=99 makes pointer from integer without a cas=
t [enabled by default]
include/linux/uaccess.h:108:21: note: expected =E2=80=98void *=E2=80=99=
 but argument is of type =E2=80=98jump_label_t=E2=80=99
arch/s390/kernel/jump_label.c:28:19: warning: unused variable =E2=80=98=
args=E2=80=99 [-Wunused-variable]
make[2]: *** [arch/s390/kernel/jump_label.o] Error 1