From: Adam Jackson Subject: Re: [PATCH] drm/i915: Probe SDVO LVDS information Date: Mon, 23 Jan 2012 11:30:07 -0500 Message-ID: <1327336207.17401.16.camel@atropine> References: <1322505131-6427-1-git-send-email-ajax@redhat.com> <20120116221952.GR3627@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0946649966==" Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id EC8FC9F4D6 for ; Mon, 23 Jan 2012 08:30:14 -0800 (PST) In-Reply-To: <20120116221952.GR3627@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0946649966== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-8k2NSjGYeR2Gup/htzg2" --=-8k2NSjGYeR2Gup/htzg2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2012-01-16 at 23:19 +0100, Daniel Vetter wrote: > On Mon, Nov 28, 2011 at 01:32:11PM -0500, Adam Jackson wrote: > > No effect besides printing the result in dmesg if debugging is enabled. > >=20 > > Signed-off-by: Adam Jackson >=20 > This looks strange without dmesg output nor a comment added. Quick survey > on irc with Jesse and Chris showed that we want interesting stuff decoded > into dmesg or debugfs ... hint ;-) > -Daniel Well: > > +static void > > +intel_sdvo_lvds_probe_panel_information(struct intel_sdvo *intel_sdvo) > > +{ > > + u8 info; > > + intel_sdvo_get_value(intel_sdvo, > > + SDVO_CMD_GET_LVDS_PANEL_INFORMATION, > > + &info, sizeof(info)); > > +} > > + > > static bool > > intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device) > > { intel_sdvo_get_value -> intel_sdvo_write_cmd / intel_sdvo_read_response, both of which call DRM_{DEBUG,LOG}_KMS. Which is a little non-obvious without an explicit "yes i'm doing this in void context, don't panic" comment in the code I guess. Want a better version? - ajax --=-8k2NSjGYeR2Gup/htzg2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAk8diw8ACgkQW4otUKDs0NOQ7wCgqP+PRBBcbhAIDfR8CVSdOOnF HcgAn0ZVuf9Cy1lxxCWzOyQv4J6ZmMPe =Ou++ -----END PGP SIGNATURE----- --=-8k2NSjGYeR2Gup/htzg2-- --===============0946649966== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0946649966==--