From: Ian Campbell Subject: Re: [PATCH 11 of 23] libxl: make libxl_device_console internal Date: Tue, 21 Feb 2012 10:23:18 +0000 Message-ID: <1329819798.25232.80.camel@dagon.hellion.org.uk> References: <20290.40164.889190.529383@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20290.40164.889190.529383@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Mon, 2012-02-20 at 19:20 +0000, Ian Jackson wrote: > Ian Campbell writes ("[Xen-devel] [PATCH 11 of 23] libxl: make libxl_device_console internal"): > > libxl: make libxl_device_console internal > > > > consoles are not directly exposed to users of the library and there are no API > > functions for manipluating them (only the console_exec function). Rather than > > commit to a particular API now make the type internal. > > Isn't it likely that at some future point we will re-expose this > difference, for example by providing a different set of access > functions ? Very likely. However I didn't want to design or commit to an API in the total absence of users. When a user does come along it is much easier to add a completely new API rather than to fix an existing broken one. It's easier to do this in a manner which users of the library can cope with in a compatible way e.g. adding a new API is easier to check for with ./configure. > The fact that all you can do with a console is exec the xenconsole > client is pretty crazy. Yup. Ian.