From: Ian Campbell Subject: Re: [PATCH 15 of 23] libxl: make boolean members of libxl_domain_create_info into libxl_defbool Date: Tue, 21 Feb 2012 10:58:40 +0000 Message-ID: <1329821920.25232.83.camel@dagon.hellion.org.uk> References: <20290.40508.50377.249022@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20290.40508.50377.249022@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Mon, 2012-02-20 at 19:25 +0000, Ian Jackson wrote: > Ian Campbell writes ("[Xen-devel] [PATCH 15 of 23] libxl: make boolean members of libxl_domain_create_info into libxl_defbool"): > > libxl: make boolean members of libxl_domain_create_info into libxl_defbool NB: should have said build_info here. > Acked-by: Ian Jackson > > > + libxl_defbool_setdefault(&b_info->u.hvm.pae, true); > > + libxl_defbool_setdefault(&b_info->u.hvm.apic, true); > > + libxl_defbool_setdefault(&b_info->u.hvm.acpi, true); > > + libxl_defbool_setdefault(&b_info->u.hvm.acpi_s3, true); > > + libxl_defbool_setdefault(&b_info->u.hvm.acpi_s4, true); > > + libxl_defbool_setdefault(&b_info->u.hvm.nx, true); > > + libxl_defbool_setdefault(&b_info->u.hvm.viridian, false); > > + libxl_defbool_setdefault(&b_info->u.hvm.hpet, true); > > + libxl_defbool_setdefault(&b_info->u.hvm.vpt_align, true); > > + libxl_defbool_setdefault(&b_info->u.hvm.nested_hvm, false); > > + libxl_defbool_setdefault(&b_info->u.hvm.usb, false); > > + libxl_defbool_setdefault(&b_info->u.hvm.xen_platform_pci, true); > > Maybe this would be easier to read like this: > > + libxl_defbool_setdefault(&b_info->u.hvm.nested_hvm, false); > + libxl_defbool_setdefault(&b_info->u.hvm.usb, false); > + libxl_defbool_setdefault(&b_info->u.hvm.xen_platform_pci, true); Seems like an improvement. I'll make that change. Ian.