From: Lucas Stach Subject: [PATCH] iommu/tegra-gart: fix spin_unlock in map failure path Date: Mon, 12 Mar 2012 20:15:01 +0100 Message-ID: <1331579701.1739.2.camel@tellur> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: iommu@lists.linux-foundation.org This must have been messed up while merging, the intention was clearly to unlock there. Signed-off-by: Lucas Stach --- drivers/iommu/tegra-gart.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c index b21598f..779306e 100644 --- a/drivers/iommu/tegra-gart.c +++ b/drivers/iommu/tegra-gart.c @@ -246,7 +246,7 @@ static int gart_iommu_map(struct iommu_domain *domain, unsigned long iova, pfn = __phys_to_pfn(pa); if (!pfn_valid(pfn)) { dev_err(gart->dev, "Invalid page: %08x\n", pa); - spin_lock_irqsave(&gart->pte_lock, flags); + spin_unlock_irqrestore(&gart->pte_lock, flags); return -EINVAL; } gart_set_pte(gart, iova, GART_PTE(pfn)); -- 1.7.7.6