From: "ordex (Code Review)"
Date: Thu, 17 Apr 2025 11:39:09 +0000
In-Reply-To:
References:
Reply-To: antonio@...2726..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
lstipakov@...277...
Message-ID: <133790d4a540b681ef9043d27d6ba8f3d7ebd8a3-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="65b3V1WFnY4="; charset=UTF-8
Subject: [Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c:
Prevent potential double-free
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: stipa
Cc: plaisthos , flichtenheld , openvpn-devel
--65b3V1WFnY4=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos, stipa.
ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/942?usp=3Demail )
Change subject: ssl_openssl.c: Prevent potential double-free
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
File src/openvpn/ssl_openssl.c:
http://gerrit.openvpn.net/c/openvpn/+/942/comment/44b20348_cad4db27 :
PS1, Line 1158: while (!OSSL_STORE_eof(store_ctx))
> Yes, this is what happened with mattock's certs.
Done
http://gerrit.openvpn.net/c/openvpn/+/942/comment/94540f39_f171d755 :
PS1, Line 1189: if (info)
there is no need for this check. Like most free() methods, passing NULL lea=
ds to nothing.
From the manpage:
OSSL_STORE_INFO_free() frees a OSSL_STORE_INFO and its contained typ=
e. If the argument is NULL, nothing is done.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/942?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4507be07cd5573b2117e837ef03187535a38a4b1
Gerrit-Change-Number: 942
Gerrit-PatchSet: 1
Gerrit-Owner: stipa
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: ordex
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Attention: stipa
Gerrit-Comment-Date: Thu, 17 Apr 2025 11:39:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: ordex
Comment-In-Reply-To: stipa
Gerrit-MessageType: comment
--65b3V1WFnY4=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos, stipa. <=
/p>
Patch set 1:Code-Review -1=
Vi=
ew Change
2 comments:
Done
Patch Set #1, Line 1189: <=
code style=3D"font-family:monospace,monospace"> if (info)
there is no need for=
this check. Like most free() methods, passing NULL leads to nothing.
From the manpage:<=
/p>
=
OSSL_STORE_INFO_free() frees a OSSL_STORE_INFO and its contained typ=
e. If the argument is NULL, nothing is done.T=
o view, visit change 942. To unsubscribe, or for help writing mail filters, visi=
t settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4507be07cd5573b2117e837ef03=
187535a38a4b1
Gerrit-Change-Number: 942
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <lstipakov@...277...>=
;
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: ordex <antonio@...2726...&=
gt;
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: stipa <lstipakov@...1663...=
.>
Gerrit-Comment-Date: Thu, 17 Apr 2025 11:39:09=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: ordex <antonio@...2787...=
...>
Comment-In-Reply-To: stipa <lstipakov@...1664...=
7...>
Gerrit-MessageType: comment
--65b3V1WFnY4=--