From: "Grodzovsky, Andrey" Subject: Re: [PATCH] add missing mutex lock to amdgpu_get_xgmi_hive() (v2) Date: Mon, 7 Jan 2019 17:00:24 +0000 Message-ID: <133f4e17-aa94-16cc-9bea-2eb16140e1de@amd.com> References: <20190107151620.11701-1-tom.stdenis@amd.com> <967dc160-e50b-0f35-b11e-6d1c9951c6aa@amd.com> <15dbfb42-df6b-74f3-877b-0680993c23b8@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: <28102BB0A2A03B49B4D6D9E0F83DCFD6-asWib9pRmPqcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "StDenis, Tom" , "Liu, Shaoyun" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" DQoNCk9uIDAxLzA3LzIwMTkgMTE6NTMgQU0sIFN0RGVuaXMsIFRvbSB3cm90ZToNCj4gT24gMjAx OS0wMS0wNyAxMTo1MSBhLm0uLCBHcm9kem92c2t5LCBBbmRyZXkgd3JvdGU6DQo+Pg0KPj4gT24g MDEvMDcvMjAxOSAxMTozNiBBTSwgU3REZW5pcywgVG9tIHdyb3RlOg0KPj4+IE9uIDIwMTktMDEt MDcgMTE6MzMgYS5tLiwgR3JvZHpvdnNreSwgQW5kcmV5IHdyb3RlOg0KPj4+PiBPbiAwMS8wNy8y MDE5IDExOjE2IEFNLCBMaXUsIFNoYW95dW4gd3JvdGU6DQo+Pj4+PiBJIHRoaW5rIGl0J3MgcmVh c29uYWJsZSB0byB1c2UgdGhlIGhpdmUgIHNwZWNpZmljIGxvY2sgZm9yIGhpdmUgIHNwZWNpZmlj IGZ1bmN0aW9ucy4NCj4+Pj4+IFRoZSBjaGFuZ2VzIGlzIGFja2VkLWJ5ICBTaGFveXVuLmxpdSA8 IFNoYW95dW4ubGl1QGFtZC5jb20+DQo+Pj4+Pg0KPj4+Pj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdl LS0tLS0NCj4+Pj4+IEZyb206IGFtZC1nZnggPGFtZC1nZngtYm91bmNlc0BsaXN0cy5mcmVlZGVz a3RvcC5vcmc+IE9uIEJlaGFsZiBPZiBTdERlbmlzLCBUb20NCj4+Pj4+IFNlbnQ6IE1vbmRheSwg SmFudWFyeSA3LCAyMDE5IDEwOjE2IEFNDQo+Pj4+PiBUbzogYW1kLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcNCj4+Pj4+IENjOiBTdERlbmlzLCBUb20gPFRvbS5TdERlbmlzQGFtZC5jb20+DQo+ Pj4+PiBTdWJqZWN0OiBbUEFUQ0hdIGFkZCBtaXNzaW5nIG11dGV4IGxvY2sgdG8gYW1kZ3B1X2dl dF94Z21pX2hpdmUoKSAodjIpDQo+Pj4+Pg0KPj4+Pj4gdjI6IE1vdmUgbG9ja3MgYXJvdW5kIGlu IG90aGVyIGZ1bmN0aW9ucyBzbyB0aGF0IHRoaXMgZnVuY3Rpb24gY2FuIHN0YW5kIG9uIGl0cyBv d24uICBBbHNvIG9ubHkgaG9sZCB0aGUgaGl2ZSBzcGVjaWZpYyBsb2NrIGZvciBhZGQvcmVtb3Zl IGRldmljZSBpbnN0ZWFkIG9mIHRoZSBkcml2ZXIgZ2xvYmFsIGxvY2sgc28geW91IGNhbid0IGFk ZC9yZW1vdmUgZGV2aWNlcyBpbiBwYXJhbGxlbCBmcm9tIG9uZSBoaXZlLg0KPj4+Pj4NCj4+Pj4+ IFNpZ25lZC1vZmYtYnk6IFRvbSBTdCBEZW5pcyA8dG9tLnN0ZGVuaXNAYW1kLmNvbT4NCj4+Pj4+ IC0tLQ0KPj4+Pj4gICAgICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rldmlj ZS5jIHwgIDIgKy0NCj4+Pj4+ICAgICAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw dV94Z21pLmMgICB8IDM2ICsrKysrKysrKysrKysrLS0tLS0tLS0NCj4+Pj4+ICAgICAgIGRyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV94Z21pLmggICB8ICAyICstDQo+Pj4+PiAgICAg ICAzIGZpbGVzIGNoYW5nZWQsIDI1IGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQ0KPj4+ Pj4NCj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVf ZGV2aWNlLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMNCj4+ Pj4+IGluZGV4IDM5ZDVkMDU4YjJjNy4uMTNkOGUyYWQyZjdhIDEwMDY0NA0KPj4+Pj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jDQo+Pj4+PiArKysgYi9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMNCj4+Pj4+IEBAIC0zNTI1 LDcgKzM1MjUsNyBAQCBpbnQgYW1kZ3B1X2RldmljZV9ncHVfcmVjb3ZlcihzdHJ1Y3QgYW1kZ3B1 X2RldmljZSAqYWRldiwNCj4+Pj4+ICAgICAgIAkgKiBieSBkaWZmZXJlbnQgbm9kZXMuIE5vIHBv aW50IGFsc28gc2luY2UgdGhlIG9uZSBub2RlIGFscmVhZHkgZXhlY3V0aW5nDQo+Pj4+PiAgICAg ICAJICogcmVzZXQgd2lsbCBhbHNvIHJlc2V0IGFsbCB0aGUgb3RoZXIgbm9kZXMgaW4gdGhlIGhp dmUuDQo+Pj4+PiAgICAgICAJICovDQo+Pj4+PiAtCWhpdmUgPSBhbWRncHVfZ2V0X3hnbWlfaGl2 ZShhZGV2KTsNCj4+Pj4+ICsJaGl2ZSA9IGFtZGdwdV9nZXRfeGdtaV9oaXZlKGFkZXYsIDApOw0K Pj4+Pj4gICAgICAgCWlmIChoaXZlICYmIGFkZXYtPmdtYy54Z21pLm51bV9waHlzaWNhbF9ub2Rl cyA+IDEgJiYNCj4+Pj4+ICAgICAgIAkgICAgIW11dGV4X3RyeWxvY2soJmhpdmUtPmhpdmVfbG9j aykpDQo+Pj4+PiAgICAgICAJCXJldHVybiAwOw0KPj4+PiBMZXQncyBzYXkgaSBoYXZlIGRldmlj ZSAwIGluIGhpdmUgQSBhbmQgaXQganVzdCBnb3QgYSBncHUgcmVzZXQgYW5kIGF0DQo+Pj4+IHRo ZSBzYW1lIHRpbWUgZGV2aWNlIDEgaXMgYmVpbmcgYWRkZWQgdG8gc2FtZSBoYXZlIHRob3VnaA0K Pj4+PiBhbWRncHVfeGdtaV9hZGRfZGV2aWNlLCBoaXZlLT5oaXZlX2xvY2sgaXMgYWNxdWlyZWQg YnkgdGhpcyBuZXcgZGV2aWNlDQo+Pj4+IGJlaW5nIGFkZGVkIGFuZCBzbyBncHUgcmVzZXQgZm9y IGRldmljZSAwIGJhaWxzIG91dCBvbg0KPj4+PiAnIW11dGV4X3RyeWxvY2soJmhpdmUtPmhpdmVf bG9jaykpJyB3aXRob3V0IGNvbXBsZXRpbmcgdGhlIHJlc2V0Lg0KPj4+PiBBbHNvIGluIGdlbmVy YWwgaSBmZWVsIGEgYml0IHVuY29tZm9ydGFibGUgYWJvdXQgdGhlIGNvbmZ1c2luZw0KPj4+PiBh Y3F1aXNpdGlvbiBzY2hlbWUgaW4gdGhlIGZ1bmN0aW9uIGFuZMKgIHRoZSBmYWN0IHRoYXQgeW91 IHRha2UgdGhlDQo+Pj4+IGhpdmUtPmhpdmVfbG9jayBpbnNpZGUgYW1kZ3B1X2dldF94Z21pX2hp dmUgYnV0IHJlbGVhc2UgaXMgc3RpbGwgb3V0c2lkZQ0KPj4+PiBvZiB0aGUgZnVuY3Rpb24uDQo+ Pj4gSXMgYWRkaW5nIGEgZGV2aWNlIHdoaWxlIHJlc2V0dGluZyBhIGRldmljZSBldmVuIGEgdmFs aWQgb3BlcmF0aW9uDQo+Pj4gYW55d2F5cz8NCj4+IEluIHRoZW9yeSBpdCdzIHZhbGlkIGlmIHlv dSBoYXZlIGhvdCBwbHVnZ2FibGUgZGV2aWNlcw0KPj4+IEkgdGhpbmsgdGhpcyBtZWFucyBtb3Jl IHNvIHRoYXQgdGhlIHJlc2V0IGxvZ2ljIGlzIGJyb2tlbi4gIEluc3RlYWQNCj4+PiB0aGVyZSBz aG91bGQgYmUgYSBwZXItaGl2ZSByZXNldCBsb2NrIHRoYXQgaXMgdGFrZW4gYW5kIHRoYXQgaXMg dGVzdGVkDQo+Pj4gaW5zdGVhZC4NCj4+Pg0KPj4+IFRvbQ0KPj4gVGhlIGhpdmUtPmhpdmVfbG9j ayB3YXMgYWRkZWQgZXhhY3RseSBmb3IgdGhpcyBwdXJwb3NlIGFuZCB1c2VkIG9ubHkgZm9yDQo+ PiB0aGF0IHB1cnBvc2UuIE1heWJlIHRoZSBuYW1pbmcgaSBnYXZlIGl0IHdhc24ndCByZWZsZWN0 aXZlIG9mIGl0J3MNCj4+IHB1cnBvc2UgOikNCj4NCj4gQnV0IHRoZSBhZGQvcmVtb3ZlIHNob3Vs ZCB1c2UgcGVyLWhpdmUgbG9ja3Mgbm90IHRoZSBnbG9iYWwgbG9jay4uLiA6LSkNCj4NCj4gKEkn bSBob25lc3RseSBub3QgdHJ5aW5nIHRvIGJpa2Ugc2hlZCBJIGp1c3QgdGhvdWdodCB0aGUgZ2V0 X2hpdmUNCj4gZnVuY3Rpb24gbG9va2VkIHdyb25nIDotKSkuDQo+DQo+IFRvbQ0KDQpUb3RhbGx5 IGFncmVlIHdpdGggeW91LCBpZiBTaGF5dW4gKHdobyBvcmlnaWFubGx5IGFkZGVkIHRoZSBnbG9i YWwgDQp4Z21pX211dGV4KSBpcyBmaW5lIHdpdGggc3dpdGNoaW5nIHRvIHBlciBoaXZlIG11dGV4 IHRoZW4gbWUgdG9vLCBJIGp1c3QgDQpwb2ludCBvdXQgdGhlIHByb2JsZW0gd2l0aCBncHUgcmVz ZXQgYW5kIGFzIHlvdSBzYWlkIHdlIHRoZW4gbmVlZCB0byANCnJlbmFtZSB0aGUgZXhpc3Rpbmcg aGl2ZV9sb2NrIGludG8gcmVzZXRfbG9jayBhbmQgdGhlbiBhbmQgYW5vdGhlciBwZXIgDQpoaXZl IGxvY2sgdG8gZG8gd2hhdCB5b3UgcHJvcG9zZS4gQWxzbyAtIGlzIHRoZXJlIGEgd2F5IHRvIG5v dCB0YWtlIHRoZSANCmhpdmUgbG9jayBpbnNpZGUgYW1kZ3B1X2dldF94Z21pX2hpdmUgYnV0IHJl bGVhc2UgaXQgb3V0c2lkZSA/IEFGQUlLIA0KaXQncyBhbiBvcGVuaW5nIGZvciBwcm9ibGVtcyB3 aGVyZSBwZW9wbGUgdXNlIGl0IGJ1dCBmb3JnZXQgdG8gY2FsbCANCnJlbGVhc2UuDQoNCkFuZHJl eQ0KDQo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fDQo+ IGFtZC1nZnggbWFpbGluZyBsaXN0DQo+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnDQo+ IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeA0K DQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4 IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK