From: Paul Menzel Subject: Re: [PATCH v5 0/4] Haswell HDMI/DP audio enable Date: Wed, 08 Aug 2012 09:14:50 +0200 Message-ID: <1344410090.4151.4.camel@mattotaupa> References: <1344395043-21129-1-git-send-email-xingchao.wang@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1850317765==" Return-path: Received: from mail.gw90.de (mail.gw90.de [188.40.100.199]) by gabe.freedesktop.org (Postfix) with ESMTP id BB00E9E85A for ; Wed, 8 Aug 2012 00:15:10 -0700 (PDT) In-Reply-To: <1344395043-21129-1-git-send-email-xingchao.wang@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Wang Xingchao Cc: tiwai@suse.de, michael.fu@intel.com, intel-gfx@lists.freedesktop.org, fengguang.wu@intel.com List-Id: intel-gfx@lists.freedesktop.org --===============1850317765== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-wbORQHn4CzOKYYLctF2r" --=-wbORQHn4CzOKYYLctF2r Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dear Wang, first is Wang your first name? Am Mittwoch, den 08.08.2012, 11:03 +0800 schrieb Wang Xingchao: > This patch series enable HDMI audio on Haswell platform, not DP audio. > The DP enablement will come after the DP patches are upstream. >=20 > I tested this patch on Sharkbay machine and i could hear clear sound from > HDMI port. Could you please add if that was a TV or a receiver? > V2 patches fixed one warning and some type errors. >=20 > V3 patches changes: > - change some registers definitions > - use macro for IBX/CPT/HSW to get registers > - remove some unused variable intended to use in TODO list. >=20 > v4 patches changes: > - remove alsa related hack patch >=20 > v5 patches changes: > - change comments stype > - split IBX/CTP registers patch into seperate one =E2=80=A2 sep*a*rate > - remove unused register definition >=20 > Here're some notes useful for you to test the patches on Sharkbay machine= : > I> please make sure your branch include below three commits in Takashi's= =20 > sound tree, othersiwe there's no proper Haswell ID and HDMI ID. =20 =E2=80=A2 White space at the end. =E2=80=A2 other*wise* > For the upstream tree, please refer to sound git tree >=20 > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git > You can just pull for-linus branch. > The all commits above are found in 3.6-rc1. >=20 > e926f2c850c472f813f9bab486c68a3fe0b03ae4 > 1c76684d2752b3a24bb7da183cc18e5d126dbcc9 > bdbe34dece4942f4d8df9865dba7785bb813366a >=20 > II> No sound from HDMI/DP. > we found it's not stable in current stage, sometimes you may not heard so= und > from HDMI or DP port, but most of the time you can heard clear sound. Aft= er > some investigation, we suspect the HDA verb didnot really make codec=20 did not > change,and we regard the GPU register as the right one. (see III explanat= ion) > the easy way is to use intel_audio_dump to compare related registers, and= make > sure the port is enabled and unmute, otherwise there's no sound. > intel_audio_tools has no support on Haswell yet, i wrote patches to make = that > happen, if you need the patches, please feel free to let me know. Here's = part > of the snapshot about port enable and mute status from intel_audio_dump: >=20 > AUD_PORT_EN_HD_CFG Port_B_Out_Enable 1 > AUD_PORT_EN_HD_CFG Port_C_Out_Enable 1 > AUD_PORT_EN_HD_CFG Port_D_Out_Enable 1 > AUD_PORT_EN_HD_CFG Port_B_Amp_Mute_Status 1 > AUD_PORT_EN_HD_CFG Port_C_Amp_Mute_Status 0 > AUD_PORT_EN_HD_CFG Port_D_Amp_Mute_Status 1 >=20 > you can see from above message, the Port C is enabled and unmute, that's = what > we expect. >=20 > III> HDA Codec dependency. When you found there's no sound from HDMI, ple= ase > use intel_audio_dump to check Port enable/mute status in II and also chec= k > related Pipe/Transcoder/DDI port status. Sometimes the pipe and transcode= r was > disabled in dpms and will not work anymore, that results in the HDMI port= no > sound. HDA codec's three converters are somehow hardwired to audio Pipes = and > if you choose the pipe, that means the regarding Codec converter should b= e > enabled too, and only one digital Pin's HDA verbs could work, that depend= s on > whehter your Pin select the converter as input. Here's one example about = the whe*th*er > Pipe/Transcoder/DDI port(Pipe B, DDI Port C): >=20 > DDI_BUF_CTL_A 0x00000080 DDI Buffer Controler A > DDI_BUF_CTL_B 0x00000000 DDI Buffer Controler B > DDI_BUF_CTL_C 0x80000000 DDI Buffer Controler C > DDI_BUF_CTL_D 0x00000000 DDI Buffer Controler D > DDI_BUF_CTL_E 0x80000002 DDI Buffer Controler E > PIPE_CONF_A 0xc0000000 PIPE Configuration A > PIPE_CONF_B 0xc0000000 PIPE Configuration B > PIPE_CONF_C 0x00000000 PIPE Configuration C > PIPE_CONF_EDP 0x00000000 PIPE Configuration EDP > PIPE_DDI_FUNC_CTL_A 0xc4034002 PIPE DDI Function Control A > PIPE_DDI_FUNC_CTL_B 0xa0035000 PIPE DDI Function Control B > PIPE_DDI_FUNC_CTL_C 0x00030000 PIPE DDI Function Control C > PIPE_DDI_FUNC_CTL_EDP 0x00030000 PIPE DDI Function Control EDP >=20 > Wang Xingchao (3): The line above should be removed. > Wang Xingchao (4): > drm/i915: HSW audio registers definition > drm/i915: write eld info for HDMI audio > drm/i915: Haswell HDMI audio enable > drm/i915: use _PIPE macro for IBX/CPT register definition >=20 > drivers/gpu/drm/i915/i915_reg.h | 71 ++++++++++++++++++++++++++++= ++++++ > drivers/gpu/drm/i915/intel_ddi.c | 6 ++- > drivers/gpu/drm/i915/intel_display.c | 52 ++++++++++++++++++++----- > 3 files changed, 118 insertions(+), 11 deletions(-) Thanks, Paul --=-wbORQHn4CzOKYYLctF2r Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEABECAAYFAlAiEeoACgkQPX1aK2wOHViBFQCbBYdvvZ3HlVp5bvXTBQuEL4BU VEoAn1ale+88LI5fHtZKbLUj9sztIn8n =d0qZ -----END PGP SIGNATURE----- --=-wbORQHn4CzOKYYLctF2r-- --===============1850317765== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1850317765==--