Message-ID: <1347023063.4256.24.camel@jlt4.sipsolutions.net> (sfid-20120907_150352_171981_016270EA)
Subject: Re: [PATCH/RFC] rfkill: prevent unnecessary event generation
From: Johannes Berg <johannes@sipsolutions.net>
To: Vitaly Wool <vitalywool@gmail.com>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	Vitaly Wool <vitaly.wool@sonymobile.com>,
	linux-wireless@vger.kernel.org
Date: Fri, 07 Sep 2012 15:04:23 +0200
In-Reply-To: <CAMJBoFNQFpM_do9EVBAQu8vtbsAiZJDJkoL9pcXwVP-Cf1=ZZg@mail.gmail.com> (sfid-20120907_150212_906177_BFAA13CF)
References: <5048ADFC.1010708@sonymobile.com>
	 <20120906224448.GA16676@khazad-dum.debian.net>
	 <CAMJBoFMd2sLEScY3j2-wsWQh3Mv_nArPC904dzJ+j-16+pdkgQ@mail.gmail.com>
	 <1347006078.4256.6.camel@jlt4.sipsolutions.net>
	 <CAMJBoFNQFpM_do9EVBAQu8vtbsAiZJDJkoL9pcXwVP-Cf1=ZZg@mail.gmail.com>
	 (sfid-20120907_150212_906177_BFAA13CF)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Fri, 2012-09-07 at 15:02 +0200, Vitaly Wool wrote:

> >> I'm not sure I got your question, but just in case, rfkill is
> >> initialized to all zeroes so rfkill->state is 0 and on each consequent
> >> _real_ change there (prev != curr) == true and the event will be
> >> generated.
> >
> > But maybe applications were expecting an event for registration? Or do
> > we get that anyway maybe?
> 
> We should get them anyway. rfkill_fop_open() basically just pushes all
> the startup events into the list so the application will see all the
> _changes_ on registration. And at least wpa_supplicant reads out all
> these events on rfkill registration. If an application does something
> else, then I think it's buggy.

Aha, good point. I guess I'll apply the patch then :)

johannes