Received: from eggs.gnu.org ([208.118.235.92]:57214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZJj3-0004zK-Ht for qemu-devel@nongnu.org; Fri, 16 Nov 2012 06:04:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZJj0-0006fJ-Fd for qemu-devel@nongnu.org; Fri, 16 Nov 2012 06:04:45 -0500 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:35608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZJj0-0006dQ-8j for qemu-devel@nongnu.org; Fri, 16 Nov 2012 06:04:42 -0500 From: Aurelien Jarno Date: Fri, 16 Nov 2012 12:04:22 +0100 Message-Id: <1353063863-11446-7-git-send-email-aurelien@aurel32.net> In-Reply-To: <1353063863-11446-1-git-send-email-aurelien@aurel32.net> References: <1353063863-11446-1-git-send-email-aurelien@aurel32.net> Subject: [Qemu-devel] [PATCH 6/7] target-mips: use DSP unions for reduction add instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Aurelien Jarno Signed-off-by: Aurelien Jarno --- target-mips/dsp_helper.c | 32 +++++++++++++++----------------- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c index 3bd2d35..474c249 100644 --- a/target-mips/dsp_helper.c +++ b/target-mips/dsp_helper.c @@ -1381,31 +1381,29 @@ target_ulong helper_modsub(target_ulong rs, target_ulong rt) target_ulong helper_raddu_w_qb(target_ulong rs) { - uint8_t rs3, rs2, rs1, rs0; - uint16_t temp; - - MIPSDSP_SPLIT32_8(rs, rs3, rs2, rs1, rs0); - - temp = (uint16_t)rs3 + (uint16_t)rs2 + (uint16_t)rs1 + (uint16_t)rs0; + target_ulong ret = 0; + DSP32Value ds; + unsigned int i; - return (target_ulong)temp; + ds.uw[0] = rs; + for (i = 0 ; i < 4 ; i++) { + ret += ds.ub[i]; + } + return ret; } #if defined(TARGET_MIPS64) target_ulong helper_raddu_l_ob(target_ulong rs) { - int i; - uint16_t rs_t[8]; - uint64_t temp; - - temp = 0; + target_ulong ret = 0; + DSP64Value ds; + unsigned int i; - for (i = 0; i < 8; i++) { - rs_t[i] = (rs >> (8 * i)) & MIPSDSP_Q0; - temp += (uint64_t)rs_t[i]; + ds.ul[0] = rs; + for (i = 0 ; i < 8 ; i++) { + ret += ds.ub[i]; } - - return temp; + return ret; } #endif -- 1.7.10.4