From: Paulo Zanoni Subject: [PATCH 0/2] Dynamic power wells support Date: Tue, 4 Dec 2012 14:48:54 -0200 Message-ID: <1354639737-3727-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-oa0-f49.google.com (mail-oa0-f49.google.com [209.85.219.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 3C31EE63B5 for ; Tue, 4 Dec 2012 08:49:11 -0800 (PST) Received: by mail-oa0-f49.google.com with SMTP id l10so4052221oag.36 for ; Tue, 04 Dec 2012 08:49:10 -0800 (PST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org From: Paulo Zanoni Hi Daniel recently sent a patch to support disabling the power well, but when reviewing it I discovered that our code to enable/disable the power well - not part of Daniel's patch, only used by it - is broken. So I created a patch to fix this problem and then ported Daniel's patch to be on top of the fix. With this, we are finally capable of correctly disabling/enabling the power well, but we are also uncovering a huge problem: we now get tons of "unclaimed register" errors, because we read/write the registers inside the "power down well" even when they're not being used. I think we can try to apply patch 01 now, but before applying patch 02 we should probably try to get rid of all those "unclaimed register" messages that it brings. This will certainly not be a small task. I can volunteer myself to do this, but considering my TODO list I will certainly not be able to address this problem before January. The first step is certainly to avoid calling ivb_disable_plane: this alone will already remove most of the error messages. Comments? Volunteers? Thanks, Paulo Daniel Vetter (1): drm/i915: dynamic Haswell display power well support Paulo Zanoni (1): drm/i915: fix intel_init_power_wells drivers/gpu/drm/i915/i915_reg.h | 8 ++--- drivers/gpu/drm/i915/intel_ddi.c | 8 ++++- drivers/gpu/drm/i915/intel_display.c | 36 ++++++++++++++++--- drivers/gpu/drm/i915/intel_drv.h | 3 +- drivers/gpu/drm/i915/intel_pm.c | 70 +++++++++++++++++++++++++++--------- 5 files changed, 98 insertions(+), 27 deletions(-) -- 1.7.11.7