From: Damien Lespiau Subject: [PATCH 4/4] drm/i915/dp: Don't log the DPCD if we are disconnected Date: Wed, 12 Dec 2012 19:50:41 +0000 Message-ID: <1355341841-4595-4-git-send-email-damien.lespiau@gmail.com> References: <1355341841-4595-1-git-send-email-damien.lespiau@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A9A0E61E4 for ; Wed, 12 Dec 2012 11:50:53 -0800 (PST) Received: by mail-wi0-f169.google.com with SMTP id hq12so3242722wib.0 for ; Wed, 12 Dec 2012 11:50:53 -0800 (PST) In-Reply-To: <1355341841-4595-1-git-send-email-damien.lespiau@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org From: Damien Lespiau It's a bit useless to print out an all null DPCD when we are disconnected and just clutter the debug logs. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_dp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index fe3c22f..42058fa 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -2362,13 +2362,13 @@ intel_dp_detect(struct drm_connector *connector, bool force) else status = g4x_dp_detect(intel_dp); + if (status != connector_status_connected) + return status; + hex_dump_to_buffer(intel_dp->dpcd, sizeof(intel_dp->dpcd), 32, 1, dpcd_hex_dump, sizeof(dpcd_hex_dump), false); DRM_DEBUG_KMS("DPCD: %s\n", dpcd_hex_dump); - if (status != connector_status_connected) - return status; - intel_dp_probe_oui(intel_dp); if (intel_dp->force_audio != HDMI_AUDIO_AUTO) { -- 1.7.11.7