Received: from eggs.gnu.org ([208.118.235.92]:57189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsxZX-0006To-Q5 for qemu-devel@nongnu.org; Wed, 09 Jan 2013 10:28:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsxZW-0007qr-H7 for qemu-devel@nongnu.org; Wed, 09 Jan 2013 10:28:07 -0500 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:56152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsxZW-0007qg-AQ for qemu-devel@nongnu.org; Wed, 09 Jan 2013 10:28:06 -0500 From: Aurelien Jarno Date: Wed, 9 Jan 2013 16:27:38 +0100 Message-Id: <1357745265-16084-2-git-send-email-aurelien@aurel32.net> In-Reply-To: <1357745265-16084-1-git-send-email-aurelien@aurel32.net> References: <1357745265-16084-1-git-send-email-aurelien@aurel32.net> Subject: [Qemu-devel] [PATCH v2 1/8] target-mips: fix DSP loads with rd = 0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Aurelien Jarno When rd is 0, which still need to do the actually load to possibly generate a TLB exception. Reviewed-by: Eric Johnson Signed-off-by: Aurelien Jarno --- target-mips/translate.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 6281e70..d1fc5af 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -12657,11 +12657,6 @@ static void gen_mipsdsp_ld(CPUMIPSState *env, DisasContext *ctx, uint32_t opc, const char *opn = "ldx"; TCGv t0; - if (rd == 0) { - MIPS_DEBUG("NOP"); - return; - } - check_dsp(ctx); t0 = tcg_temp_new(); -- 1.7.10.4