Return-Path: From: Xi Wang To: linux-kernel@vger.kernel.org Cc: "Eric W. Biederman" , Xi Wang , stable@vger.kernel.org Subject: [PATCH] sysctl: fix null checking in bin_dn_node_address() Date: Tue, 22 Jan 2013 09:58:25 -0500 Message-Id: <1358866705-30690-1-git-send-email-xi.wang@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: The null check of `strchr() + 1' is broken, which is always non-null, leading to OOB read. Instead, check the result of strchr(). Signed-off-by: Xi Wang Cc: stable@vger.kernel.org --- kernel/sysctl_binary.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c index 5a63844..0ddf3a0 100644 --- a/kernel/sysctl_binary.c +++ b/kernel/sysctl_binary.c @@ -1194,9 +1194,10 @@ static ssize_t bin_dn_node_address(struct file *file, /* Convert the decnet address to binary */ result = -EIO; - nodep = strchr(buf, '.') + 1; + nodep = strchr(buf, '.'); if (!nodep) goto out; + ++nodep; area = simple_strtoul(buf, NULL, 10); node = simple_strtoul(nodep, NULL, 10); -- 1.7.10.4