From: David Howells Subject: Re: [PATCH 0/8] ceph: fscache support & upstream changes Date: Mon, 09 Sep 2013 11:17:58 +0100 Message-ID: <13594.1378721878@warthog.procyon.org.uk> References: <18764.1378483142@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-cachefs-bounces@redhat.com Errors-To: linux-cachefs-bounces@redhat.com To: Milosz Tanski Cc: Sage Weil , linux-kernel@vger.kernel.org, "linux-fsdevel@vger.kernel.org" , "linux-cachefs@redhat.com" , sprabhu@redhat.com, "Yan, Zheng" , ceph-devel List-Id: ceph-devel.vger.kernel.org Milosz Tanski wrote: > - (1 << FSCACHE_OP_WAITING); > + (1 << FSCACHE_OP_WAITING) | > + (1 << FSCACHE_OP_UNUSE_COOKIE); Yeah... That'll do it. We could just decrement n_active directly after calling into the backend - after all, we cannot reduce n_active to 0 here because the netfs cannot be calling fscache_relinquish_cookie() whilst also calling this function - but this will do too. David