From: Lubomir Rintel Date: Thu, 31 Jan 2013 12:02:24 +0100 Subject: [U-Boot] [PATCH] env: Allow accessing non-mtd devices In-Reply-To: <20130131064855.D072E20059E@gemini.denx.de> References: <1359589584-19846-1-git-send-email-lkundrak@v3.sk> <20130131064855.D072E20059E@gemini.denx.de> Message-ID: <1359630144.16475.6.camel@hobbes> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 2013-01-31 at 07:48 +0100, Wolfgang Denk wrote: > Dear Lubomir Rintel, > > In message <1359589584-19846-1-git-send-email-lkundrak@v3.sk> you wrote: > > In certain cases, memory device is present as flat file or block device (via > > mmc or mtdblock layer). Do not attempt MTD operations against it. > > What exactly would be such cases? Mine is a Kobo Mini e-book reader, which is basically Freescale MX50 with the only storage there being an MMC/SD card (removable from a slot if disassembled), which contains uboot and its environment as well as partition table, root and storage volume. Apart from wiring a serial console, running fw_* tools seems to be about the only way to modify kernel command line on that device. Also, I can imagine that it would be useful to prepare a flat file image on a different computer and copy it to the image afterwards. > Please also make sure to run your patch through checkpatch - it > catches a number of "space prohibited between function name and open > parenthesis" warnings I tried to stick with the coding style already present in the file. No problem though, I'll follow up with an updated patch later. > and tells you that your Signed-off-by: line is > missing. Noted, will fix. Thank you! Lubo