From: Jaegeuk Kim Subject: Re: [PATCH 1/6] f2fs: optimize get node page readahead part Date: Mon, 04 Feb 2013 10:38:36 +0900 Message-ID: <1359941916.26950.12.camel@kjgkr> References: <1359816711-16252-1-git-send-email-linkinjeon@gmail.com> Reply-To: jaegeuk.kim@samsung.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-vvDlUES8vn9pYe2ycaRl" Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Namjae Jeon , Amit Sahrawat To: Namjae Jeon Return-path: In-reply-to: <1359816711-16252-1-git-send-email-linkinjeon@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org --=-vvDlUES8vn9pYe2ycaRl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, 2013-02-02 (=ED=86=A0), 23:51 +0900, Namjae Jeon: > From: Namjae Jeon >=20 > We can remove the call to find_get_page to get a page from the cache > and check for up-to-date, instead we can make use of grab_cache_page > part itself to fetch the page from the cache. > So, removing the call and moving the PageUptodate at proper place, also > taken care of moving the lock_page condition in the page_hit part. >=20 > Signed-off-by: Namjae Jeon > Signed-off-by: Amit Sahrawat > --- > fs/f2fs/node.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) >=20 > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index 33fa6d5..723185b 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -920,15 +920,12 @@ struct page *get_node_page_ra(struct page *parent, = int start) > if (!nid) > return ERR_PTR(-ENOENT); > =20 > - page =3D find_get_page(mapping, nid); > - if (page && PageUptodate(page)) > - goto page_hit; > - f2fs_put_page(page, 0); > - The reason why we use this is to avoid the lock overhead. This is a readahead flow, and we don't need to care about real existence. Let's get and check the status of the page without any locks. Thanks, --=20 Jaegeuk Kim Samsung --=-vvDlUES8vn9pYe2ycaRl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJRDxEcAAoJEEAUqH6CSFDSmvcP/R6BIj9Cu1qMlN9eGoflzUAf Goi//FvMUJAPV5jTZejZfmZZ00FQTsDrH5T8ogpE6SGkXNdLvGCf8zSb5z1ROvmk fY4IHO1wfVJjpt1mXtTuRNGYXCp4VkLYH7N+zQZxDWVZ5c770rQUBTDv4AqiZ8/5 GOHsuoqWNT0gtRyi1B+Opcpex8kwYtuDuRMmFx+0dY5GX4bR6hsH3/zTRxbRA6M1 vp7Xre/OX0pK60XEVRnsV8fyRn9wIFyaIsIvanAqgLjV3QbBG8Osm2+Ptl+RMr4n I57FmBXHFgPKeeLYLm1QUCf5IzmpRKEJitezmwNXeeCnaoH6ZXKygudKFIfUkAUP aQUOMEMN0FFZGZyy22jpzj+4o4zk7yYkQgr39BR6lje1qvqeyBAA/fXkrth200Sk rchp1znTUnuSvqEvasUU4NRk+XJ3UNp0iTqhU0aj3dFH0IuSeFeUJDfCZDd2msTt pjtOXCg/IGEZ7yoHbGqZ2Z/aeiwgyXQ3wTR4DnbFslPxXeQve1gIChMLA+aXesK3 aCWEb56RzoDurjX/eKDYMTH+nmY9Xc29MmJiZrBUHl8cKojCX5Ki96+QFAP4U3GG 5qcq8YowsjfxWOFQD7jQu2jbyV3J3djT08w8qHSya4kVFMg8ASoHDBEhE3VMZU6h sIRlAIx8/a6d+5+/H5I9 =Pxm9 -----END PGP SIGNATURE----- --=-vvDlUES8vn9pYe2ycaRl--