From: Ian Campbell Subject: Re: [PATCH 1/4] Adding support for coverage information Date: Wed, 6 Feb 2013 08:35:01 +0000 Message-ID: <1360139701.9063.40.camel@dagon.hellion.org.uk> References: <1360079900-31777-1-git-send-email-frediano.ziglio@citrix.com> <1360079900-31777-2-git-send-email-frediano.ziglio@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1360079900-31777-2-git-send-email-frediano.ziglio@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Frediano Ziglio Cc: George Dunlap , Konrad Rzeszutek Wilk , "Keir (Xen.org)" , Jan Beulich , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Tue, 2013-02-05 at 15:58 +0000, Frediano Ziglio wrote: > +void __init init_coverage(void) > +{ > + unsigned long n; > + for ( n = 0; n < __CTOR_LIST__.count; ++n ) > + __CTOR_LIST__.funcs[n](); There is nothing coverage specific here, why not run these from a generic function? Ian.