From: Jaegeuk Kim Subject: Re: [PATCH] f2fs: fix to name f2fs GC task as per partition instead of per device Date: Wed, 06 Feb 2013 18:21:46 +0900 Message-ID: <1360142506.26950.56.camel@kjgkr> References: <1360074293-8252-1-git-send-email-linkinjeon@gmail.com> <1360125680.26950.55.camel@kjgkr> Reply-To: jaegeuk.kim@samsung.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-tBgxyatIYjWEYNsvbtS0" Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Namjae Jeon , Amit Sahrawat To: Namjae Jeon Return-path: In-reply-to: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org --=-tBgxyatIYjWEYNsvbtS0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, 2013-02-06 (=EC=88=98), 13:59 +0900, Namjae Jeon: > 2013/2/6, Jaegeuk Kim : > > Hi, > > > > How about this? > > > > 2013-02-05 (=ED=99=94), 23:24 +0900, Namjae Jeon: > >> From: Namjae Jeon > >> > >> After the commit 2184ad190a79ae2b40b5f5db1fbde5c22db6d310, it allowed > >> for naming GC threads based on the device. > >> i.e., if we have F2FS formatted partition in different devices - we wi= ll > >> have their GC thread names after the device. But, when we have a case > >> like > >> 2 or more partitions on the same device having F2FS filesystem. > >> In that case we are not able to differentiate between the GC threads. > >> So, to differentiate at all possible levels we can use the major/minor= of > >> the device to have unique identification in the name. > >> > >> Before patch: > >> root 9726 0.0 0.0 0 0 ? S 14:32 0:00 [f2fs_gc-8:48] > >> root 9736 0.0 0.0 0 0 ? S 14:32 0:00 [f2fs_gc-8:16] > >> root 9892 0.0 0.0 0 0 ? S 14:33 0:00 [f2fs_gc-8:32] > >> root 9907 0.0 0.0 0 0 ? S 14:34 0:00 [f2fs_gc-8:32] > >> > >> After Patch: > >> root 16756 0.0 0.0 0 0 ? S 14:57 0:00 [f2fs_gc-8:18] > >> root 16765 0.0 0.0 0 0 ? S 14:57 0:00 [f2fs_gc-8:19] > >> root 16806 0.0 0.0 0 0 ? S 14:58 0:00 [f2fs_gc-8:34] > >> root 16817 0.0 0.0 0 0 ? S 14:58 0:00 [f2fs_gc-8:52] > >> > > > > root 16756 0.0 0.0 0 0 ? S 14:57 0:00 [f2fs_gc-sdb1] > > root 16765 0.0 0.0 0 0 ? S 14:57 0:00 [f2fs_gc-sdb2] > > > > IMO, it would be better to describe like this. > > We can simply use bdevname(bdev, name), so if no objection, I'll rebase > > this patch with this. > > Please, give me your opinion. > > Thanks, > Hi Jaegeuk. >=20 > Although it is good opinion to have user friendly names in the task > list, but we cannot have such names. >=20 > Because, even though bdevname() will provide the correct string. But > there is a limitation from the task struct command length. > The Task struct allows for the name to be maximum of =E2=80=9816=E2=80=99= characters in length. > char comm[TASK_COMM_LEN]; >=20 > /* Task command name length */ > #define TASK_COMM_LEN 16 > So, the task name would be truncated to =E2=80=9816=E2=80=99 characters. >=20 > In case like for MMC partitions where partition name can be like: > mmcblk0p18, the name would become f2fs_gc-mmcblk0p18 -> this will be > truncate to =E2=80=9Cf2fs_gc-mmcblk0p=E2=80=9D Agreed. Thank you for explanation. :) >=20 > Let me know your opinion. > Thanks. > > > > > >> Signed-off-by: Namjae Jeon > >> Signed-off-by: Amit Sahrawat > >> --- > >> fs/f2fs/gc.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > >> index 742135a..b0c1f8c 100644 > >> --- a/fs/f2fs/gc.c > >> +++ b/fs/f2fs/gc.c > >> @@ -91,6 +91,7 @@ static int gc_thread_func(void *data) > >> int start_gc_thread(struct f2fs_sb_info *sbi) > >> { > >> struct f2fs_gc_kthread *gc_th; > >> + dev_t dev =3D sbi->sb->s_bdev->bd_dev; > >> > >> if (!test_opt(sbi, BG_GC)) > >> return 0; > >> @@ -101,7 +102,7 @@ int start_gc_thread(struct f2fs_sb_info *sbi) > >> sbi->gc_thread =3D gc_th; > >> init_waitqueue_head(&sbi->gc_thread->gc_wait_queue_head); > >> sbi->gc_thread->f2fs_gc_task =3D kthread_run(gc_thread_func, sbi, > >> - "f2fs_gc-%s", dev_name(sbi->sb->s_bdi->dev)); > >> + "f2fs_gc-%u:%u", MAJOR(dev), MINOR(dev)); > >> if (IS_ERR(gc_th->f2fs_gc_task)) { > >> kfree(gc_th); > >> sbi->gc_thread =3D NULL; > > > > -- > > Jaegeuk Kim > > Samsung > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" = in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --=20 Jaegeuk Kim Samsung --=-tBgxyatIYjWEYNsvbtS0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJREiCqAAoJEEAUqH6CSFDS1qAP/R5FTzFvY9zNcL/iHDK71seS P8V2JTfq8lnrj9qxI0Fwyq8bsGX/tnXtRQukwf5NQuYh9IG6gVE/Ik11ytD3A8yi 6ghvSYz2BnVBRkVV1a5sFdivnp4DZsCrxXZj2229UnXtIW+rK+bB7Q/3WFm+E/Rn FM3elBKdyJllyrpCSeiua2EjhXK6Co+/Ui0GkCX4dpqeUNgMckRf/FcN+gDaRtjG kCinrKDLphuxwPDMiRvrQRUgeMyASLvVrRZry6Zc6aYlmUPbQBgCBZWZWBTmxn7q wuou/rItCidBZE+pPGGugjBLTp/ReY4TS8gCVvWn/7qcOXUELeIzkLvm7r22qn54 EmnR4bX1frzE3qaqRMm5ykD8NQstOhrjoQzW8RCC2bC8npoIb0l5EWcQopb9bynA ECcRO0fRRb8+kyqYk8Ac11s92wguoHlnkMUoTHlD/2E7SrvUG8Rd2lSXcOIpTZZp VWkksCv38xCAdrGLty1A6jRJUnbFY11Z8ObwKhb1tTjEmsf4Uxtt9ck8UwGAccA1 68i1ikFPULzxihChgaAr/cd4vVPMOhswrw2YXYtXlE0lqGHN3wO9suUcjIjqA0pz 7VqgBO/aS19th0/toMMmS0g1LOrsIDJR1R3ThYY6iBGQ/zvedhF/rlogS0nbJFMt H+aSEVKOrm0TUEyN0PuN =yKAz -----END PGP SIGNATURE----- --=-tBgxyatIYjWEYNsvbtS0--