From: Ian Campbell Subject: Re: [PATCH] build: Fix distclean when repo location changes Date: Wed, 20 Feb 2013 17:01:22 +0000 Message-ID: <1361379682.26546.18.camel@zakaz.uk.xensource.com> References: <8f69a0bcab522d7dae5a.1361378871@st28.blah> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <8f69a0bcab522d7dae5a.1361378871@st28.blah> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrei Lifchits Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Wed, 2013-02-20 at 16:47 +0000, Andrei Lifchits wrote: > If the path to xen-unstable.hg changes (i.e. you move the repo), the symlinks > inside xen-unstable.hg/stubdom/libxc-x86_[32|64]/ all become broken, which > breaks distclean because make attempts to clean inside those first and fails to > find Makefile (which is also a symlink). Would it be possible to arrange for the symlinks to be relative in the first place? > > diff -r 66f563be41d9 -r 8f69a0bcab52 stubdom/Makefile > --- a/stubdom/Makefile Tue Feb 19 10:49:53 2013 +0100 > +++ b/stubdom/Makefile Wed Feb 20 16:36:40 2013 +0000 > @@ -501,7 +501,7 @@ clean: > $(MAKE) -C vtpmmgr clean > rm -fr grub-$(XEN_TARGET_ARCH) > rm -f $(STUBDOMPATH) > - [ ! -d libxc-$(XEN_TARGET_ARCH) ] || $(MAKE) DESTDIR= -C libxc-$(XEN_TARGET_ARCH) clean > + [ ! -e libxc-$(XEN_TARGET_ARCH)/Makefile ] || $(MAKE) DESTDIR= -C libxc-$(XEN_TARGET_ARCH) clean > -[ ! -d ioemu ] || $(MAKE) DESTDIR= -C ioemu clean > -[ ! -d xenstore ] || $(MAKE) DESTDIR= -C xenstore clean > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel