From: Ian Campbell Subject: Re: [PATCH V2 05/46] xen: arm64: initial build + config changes, start of day code Date: Thu, 21 Feb 2013 15:26:07 +0000 Message-ID: <1361460367.26546.63.camel@zakaz.uk.xensource.com> References: <1360860465.20449.472.camel@zakaz.uk.xensource.com> <1360860480-9245-5-git-send-email-ian.campbell@citrix.com> <20130221145628.GN24051@ocelot.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130221145628.GN24051@ocelot.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: Stefano Stabellini , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Thu, 2013-02-21 at 14:56 +0000, Tim Deegan wrote: > At 16:47 +0000 on 14 Feb (1360860439), Ian Campbell wrote: > > +2: PRINT("- Started in Hyp mode -\r\n") > > + > > +hyp: > > I though we were going to use "EL3" instead of "Hyp". Sorry, looks like I missed a few comments when I went through this one. > > > + /* Non-boot CPUs need to move on to the relocated pagetables */ > > + //mov x0, #0 > > This line should go. > > > +/* > > + * xen/arch/arm/arm64/mode_switch.S > > + * > > + * Start-of day code to take a CPU from EL3 to EL2. Largely taken from > > + bootwrapper. > > Still missing a *. > > Tim.