From: Wei Liu Subject: [RFC PATCH V3 02/22] Dynamically allocate d->evtchn Date: Wed, 27 Feb 2013 14:33:55 +0000 Message-ID: <1361975655-22295-3-git-send-email-wei.liu2@citrix.com> References: <1361975655-22295-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1361975655-22295-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org, jbeulich@suse.com, keir@xen.org, ian.campbell@citrix.com Cc: Wei Liu , david.vrabel@citrix.com List-Id: xen-devel@lists.xenproject.org As we move to N level evtchn we need bigger d->evtchn, as a result this will bloat struct domain. So move this array out of struct domain and allocate a dedicated page for it. Signed-off-by: Wei Liu --- xen/common/event_channel.c | 17 +++++++++++++++-- xen/include/xen/sched.h | 2 +- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index 9231eb0..3293f91 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -1172,15 +1172,26 @@ void notify_via_xen_event_channel(struct domain *ld, int lport) int evtchn_init(struct domain *d) { + BUILD_BUG_ON(sizeof(struct evtchn *) * NR_EVTCHN_BUCKETS > PAGE_SIZE); + d->evtchn = alloc_xenheap_page(); + + if ( d->evtchn == NULL ) + return -ENOMEM; + clear_page(d->evtchn); + spin_lock_init(&d->event_lock); - if ( get_free_port(d) != 0 ) + if ( get_free_port(d) != 0 ) { + free_xenheap_page(d->evtchn); return -EINVAL; + } evtchn_from_port(d, 0)->state = ECS_RESERVED; #if MAX_VIRT_CPUS > BITS_PER_LONG d->poll_mask = xmalloc_array(unsigned long, BITS_TO_LONGS(MAX_VIRT_CPUS)); - if ( !d->poll_mask ) + if ( !d->poll_mask ) { + free_xenheap_page(d->evtchn); return -ENOMEM; + } bitmap_zero(d->poll_mask, MAX_VIRT_CPUS); #endif @@ -1214,6 +1225,8 @@ void evtchn_destroy(struct domain *d) spin_unlock(&d->event_lock); clear_global_virq_handlers(d); + + free_xenheap_page(d->evtchn); } diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index f6846d4..812bd87 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -260,7 +260,7 @@ struct domain spinlock_t rangesets_lock; /* Event channel information. */ - struct evtchn *evtchn[NR_EVTCHN_BUCKETS]; + struct evtchn **evtchn; spinlock_t event_lock; struct grant_table *grant_table; -- 1.7.10.4