From: xulei Date: Tue, 5 Mar 2013 18:07:58 +0800 Subject: [U-Boot] [PATCH] powerpc/85xx: Add workaround for errata USB-14 (enable on P204x/P3041/P50x0) In-Reply-To: <20130304092432.A4867200246@gemini.denx.de> References: <1362368146-738-1-git-send-email-B33228@freescale.com> <20130304092432.A4867200246@gemini.denx.de> Message-ID: <1362478078.3463.2.camel@xulei-desktop> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello, Wolfgang Thank you, will modify it in the next version. Regards Lei On Monday, 2013-03-04 at 10:24 +0100, Wolfgang Denk wrote: > Dear xulei, > > In message <1362368146-738-1-git-send-email-B33228@freescale.com> you wrote: > > > > + /* On P204x/P304x/P50x0 Rev1.0, USB transmit will result internal > > + * multi-bit ECC errors, which has impact on performance, so software > > + * should disable all ECC reporting from USB1 and USB2 by setting bits > > + * 16 and 17 to 1 in the register at DCSRBASE + 0x0002_0520. > > + */ > > +#ifdef CONFIG_SYS_FSL_ERRATUM_USB14 > > + if (IS_SVR_REV(get_svr(), 1, 0)) { > > + void *p; > > + p = (void *)CONFIG_SYS_DCSRBAR + 0x20520; > > + setbits_be32(p, 3 << (31 - 17)); > > + } > > +#endif > > Please move the comment inside the #ifdef block. > > Best regards, > > Wolfgang Denk >