From: xulei Date: Tue, 5 Mar 2013 18:27:57 +0800 Subject: [U-Boot] [PATCH] powerpc/85xx: Add workaround for errata USB-14 (enable on P204x/P3041/P50x0) In-Reply-To: <20130304092603.53CD3200246@gemini.denx.de> References: <1362368146-738-1-git-send-email-B33228@freescale.com> <20130304092603.53CD3200246@gemini.denx.de> Message-ID: <1362479277.3463.18.camel@xulei-desktop> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello, Wolfgang Thank you and I agree with you. It is a little ugly but because these registers info are not publicly, so I did not use C struct to describe them, then for this case it it ok or other method such as define a struct but keep all other registers and bits in this register reserved? or any method better? Thank you. Regards Lei On Monday, 2013-03-04 at 10:26 +0100, Wolfgang Denk wrote: > Dear xulei, > > In message <1362368146-738-1-git-send-email-B33228@freescale.com> you wrote: > > On P204x/P304x/P50x0 Rev1.0, USB transmit will result in false internal > > multi-bit ECC errors, which has impact on performance, so software should > > disable all ECC reporting from USB1 and USB2 by setting bits 16 and 17 to 1 > > in the register at DCSRBASE + 0x0002_0520. > ... > > + void *p; > > + p = (void *)CONFIG_SYS_DCSRBAR + 0x20520; > > Um... and don't we have a proper C struct that describes the registers > in this area? > > We don't allow base address + offset addressing like this. > > Best regards, > > Wolfgang Denk >