Received: from eggs.gnu.org ([208.118.235.92]:58196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGXDr-0001W8-1O for qemu-devel@nongnu.org; Fri, 15 Mar 2013 12:11:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UGXDm-0006Ir-O5 for qemu-devel@nongnu.org; Fri, 15 Mar 2013 12:11:10 -0400 Received: from [2a02:248:0:30:223:aeff:fefe:7f1c] (port=48337 helo=dns.kamp-intra.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGXDm-0006H1-Hu for qemu-devel@nongnu.org; Fri, 15 Mar 2013 12:11:06 -0400 From: Peter Lieven Date: Fri, 15 Mar 2013 16:50:14 +0100 Message-Id: <1363362619-3190-6-git-send-email-pl@kamp.de> In-Reply-To: <1363362619-3190-1-git-send-email-pl@kamp.de> References: <1363362619-3190-1-git-send-email-pl@kamp.de> Subject: [Qemu-devel] [PATCHv2 5/9] migration: search for zero instead of dup pages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Lieven virtually all dup pages are zero pages. remove the speical is_dup_page() function and use the optimized buffer_is_zero() function instead. Signed-off-by: Peter Lieven --- arch_init.c | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/arch_init.c b/arch_init.c index 1b71912..87c16fc 100644 --- a/arch_init.c +++ b/arch_init.c @@ -144,21 +144,6 @@ int qemu_read_default_config_files(bool userconfig) return 0; } -static int is_dup_page(uint8_t *page) -{ - VECTYPE *p = (VECTYPE *)page; - VECTYPE val = SPLAT(page); - int i; - - for (i = 0; i < TARGET_PAGE_SIZE / sizeof(VECTYPE); i++) { - if (!ALL_EQ(val, p[i])) { - return 0; - } - } - - return 1; -} - /* struct contains XBZRLE cache and a static page used by the compression */ static struct { @@ -443,7 +428,7 @@ static int ram_save_block(QEMUFile *f, bool last_stage) /* In doubt sent page as normal */ bytes_sent = -1; - if (is_dup_page(p)) { + if (buffer_is_zero(p, TARGET_PAGE_SIZE)) { acct_info.dup_pages++; bytes_sent = save_block_hdr(f, block, offset, cont, RAM_SAVE_FLAG_COMPRESS); -- 1.7.9.5