Received: from eggs.gnu.org ([208.118.235.92]:46248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIfSf-0005Sm-3R for qemu-devel@nongnu.org; Thu, 21 Mar 2013 09:23:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIfSd-0008E2-Eu for qemu-devel@nongnu.org; Thu, 21 Mar 2013 09:23:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8235) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIfSd-0008Dj-7M for qemu-devel@nongnu.org; Thu, 21 Mar 2013 09:23:15 -0400 From: Orit Wasserman Date: Thu, 21 Mar 2013 15:23:48 +0200 Message-Id: <1363872230-15081-7-git-send-email-owasserm@redhat.com> In-Reply-To: <1363872230-15081-1-git-send-email-owasserm@redhat.com> References: <1363872230-15081-1-git-send-email-owasserm@redhat.com> Subject: [Qemu-devel] [PATCH v2 6/8] More optimized qemu_put_be64/32/16 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Orit Wasserman , pbonzini@redhat.com, mst@redhat.com, chegu_vinod@hp.com, quintela@redhat.com qemu_put_be functions used qemu_put_byte this caused lots of 1 bytes buffers in the iovec. we move to use cpu_put_be64/32/16wu and put a single buffer per call. Signed-off-by: Orit Wasserman --- savevm.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/savevm.c b/savevm.c index fde59d3..b724527 100644 --- a/savevm.c +++ b/savevm.c @@ -789,22 +789,26 @@ void qemu_file_reset_rate_limit(QEMUFile *f) void qemu_put_be16(QEMUFile *f, unsigned int v) { - qemu_put_byte(f, v >> 8); - qemu_put_byte(f, v); + uint16_t p; + cpu_to_be16wu(&p, v); + + qemu_put_buffer(f, (uint8_t *)&p, sizeof(p)); } void qemu_put_be32(QEMUFile *f, unsigned int v) { - qemu_put_byte(f, v >> 24); - qemu_put_byte(f, v >> 16); - qemu_put_byte(f, v >> 8); - qemu_put_byte(f, v); + uint32_t p; + cpu_to_be32wu(&p, v); + + qemu_put_buffer(f, (uint8_t *)&p, sizeof(p)); } void qemu_put_be64(QEMUFile *f, uint64_t v) { - qemu_put_be32(f, v >> 32); - qemu_put_be32(f, v); + uint64_t p; + cpu_to_be64wu(&p, v); + + qemu_put_buffer(f, (uint8_t *)&p, sizeof(p)); } unsigned int qemu_get_be16(QEMUFile *f) -- 1.7.11.7