Received: from eggs.gnu.org ([208.118.235.92]:59384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UJ5I7-0001pv-7V for qemu-devel@nongnu.org; Fri, 22 Mar 2013 12:58:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UJ5I6-0000xz-0X for qemu-devel@nongnu.org; Fri, 22 Mar 2013 12:58:07 -0400 Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 22 Mar 2013 17:57:48 +0100 Message-Id: <1363971468-21154-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH] qemu-bridge-helper: force usage of a very high MAC address for the bridge List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: coreyb@linux.vnet.ibm.com, qemu-stable@nongnu.org Linux uses the lowest enslaved MAC address as the MAC address of the bridge. Set MAC address to a high value so that it does not affect the MAC address of the bridge. Changing the MAC address of the bridge could cause a few seconds of network downtime. Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini --- qemu-bridge-helper.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c index 287bfd5..6a0974e 100644 --- a/qemu-bridge-helper.c +++ b/qemu-bridge-helper.c @@ -367,6 +367,24 @@ int main(int argc, char **argv) goto cleanup; } + /* Linux uses the lowest enslaved MAC address as the MAC address of + * the bridge. Set MAC address to a high value so that it doesn't + * affect the MAC address of the bridge. + */ + if (ioctl(ctlfd, SIOCGIFHWADDR, &ifr) < 0) { + fprintf(stderr, "failed to get MAC address of device `%s': %s\n", + iface, strerror(errno)); + ret = EXIT_FAILURE; + goto cleanup; + } + ifr.ifr_hwaddr.sa_data[0] = 0xFE; + if (ioctl(ctlfd, SIOCSIFHWADDR, &ifr) < 0) { + fprintf(stderr, "failed to set MAC address of device `%s': %s\n", + iface, strerror(errno)); + ret = EXIT_FAILURE; + goto cleanup; + } + /* add the interface to the bridge */ prep_ifreq(&ifr, bridge); ifindex = if_nametoindex(iface); -- 1.8.1.4