Received: from eggs.gnu.org ([208.118.235.92]:55401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKQgx-0005Dn-JP for qemu-devel@nongnu.org; Tue, 26 Mar 2013 06:01:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKQgr-0006Ps-Fp for qemu-devel@nongnu.org; Tue, 26 Mar 2013 06:01:19 -0400 Received: from [2a02:248:0:30:223:aeff:fefe:7f1c] (port=49001 helo=dns.kamp-intra.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKQgr-0006Pg-9a for qemu-devel@nongnu.org; Tue, 26 Mar 2013 06:01:13 -0400 From: Peter Lieven Date: Tue, 26 Mar 2013 10:58:34 +0100 Message-Id: <1364291919-19563-6-git-send-email-pl@kamp.de> In-Reply-To: <1364291919-19563-1-git-send-email-pl@kamp.de> References: <1364291919-19563-1-git-send-email-pl@kamp.de> Subject: [Qemu-devel] [PATCHv5 05/10] bitops: unroll while loop in find_next_bit() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: quintela@redhat.com, Stefan Hajnoczi , Peter Lieven , Orit Wasserman , Paolo Bonzini this patch adopts the loop unrolling idea of bitmap_is_zero() to speed up the skipping of large areas with zeros in find_next_bit(). this routine is extensively used to find dirty pages in live migration. testing only the find_next_bit performance on a zeroed bitfield the loop onrolling decreased executing time by approx. 50% on x86_64. Signed-off-by: Peter Lieven --- util/bitops.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/util/bitops.c b/util/bitops.c index e72237a..227c38b 100644 --- a/util/bitops.c +++ b/util/bitops.c @@ -42,7 +42,23 @@ unsigned long find_next_bit(const unsigned long *addr, unsigned long size, size -= BITS_PER_LONG; result += BITS_PER_LONG; } - while (size & ~(BITS_PER_LONG-1)) { + while (size >= 4*BITS_PER_LONG) { + unsigned long d1, d2, d3; + tmp = *p; + d1 = *(p+1); + d2 = *(p+2); + d3 = *(p+3); + if (tmp) { + goto found_middle; + } + if (d1 | d2 | d3) { + break; + } + p += 4; + result += 4*BITS_PER_LONG; + size -= 4*BITS_PER_LONG; + } + while (size >= BITS_PER_LONG) { if ((tmp = *(p++))) { goto found_middle; } -- 1.7.9.5