Received: from eggs.gnu.org ([208.118.235.92]:38921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKZ8E-0004tw-Ql for qemu-devel@nongnu.org; Tue, 26 Mar 2013 15:02:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKZ8A-0005s6-K1 for qemu-devel@nongnu.org; Tue, 26 Mar 2013 15:02:02 -0400 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:49208) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKZ8A-0005o1-AR for qemu-devel@nongnu.org; Tue, 26 Mar 2013 15:01:58 -0400 From: Aurelien Jarno Date: Tue, 26 Mar 2013 20:01:34 +0100 Message-Id: <1364324502-9124-3-git-send-email-aurelien@aurel32.net> In-Reply-To: <1364324502-9124-1-git-send-email-aurelien@aurel32.net> References: <1364324502-9124-1-git-send-email-aurelien@aurel32.net> Subject: [Qemu-devel] [PATCH 02/10] target-i386: SSE4.2: fix pcmpgtq instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Aurelien Jarno The "Intel 64 and IA-32 Architectures Software Developer's Manual" (at least recent versions) clearly says that the comparison is signed. Signed-off-by: Aurelien Jarno --- target-i386/ops_sse.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target-i386/ops_sse.h b/target-i386/ops_sse.h index cad9d75..0136df9 100644 --- a/target-i386/ops_sse.h +++ b/target-i386/ops_sse.h @@ -1933,8 +1933,7 @@ void glue(helper_mpsadbw, SUFFIX)(CPUX86State *env, Reg *d, Reg *s, } /* SSE4.2 op helpers */ -/* it's unclear whether signed or unsigned */ -#define FCMPGTQ(d, s) (d > s ? -1 : 0) +#define FCMPGTQ(d, s) ((int64_t)d > (int64_t)s ? -1 : 0) SSE_HELPER_Q(helper_pcmpgtq, FCMPGTQ) static inline int pcmp_elen(CPUX86State *env, int reg, uint32_t ctrl) -- 1.7.10.4