Received: from eggs.gnu.org ([208.118.235.92]:38941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKZ8G-0004u9-6I for qemu-devel@nongnu.org; Tue, 26 Mar 2013 15:02:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKZ8A-0005rl-Hp for qemu-devel@nongnu.org; Tue, 26 Mar 2013 15:02:04 -0400 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:49207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKZ8A-0005nz-A8 for qemu-devel@nongnu.org; Tue, 26 Mar 2013 15:01:58 -0400 From: Aurelien Jarno Date: Tue, 26 Mar 2013 20:01:38 +0100 Message-Id: <1364324502-9124-7-git-send-email-aurelien@aurel32.net> In-Reply-To: <1364324502-9124-1-git-send-email-aurelien@aurel32.net> References: <1364324502-9124-1-git-send-email-aurelien@aurel32.net> Subject: [Qemu-devel] [PATCH 06/10] target-i386: SSE4.2: fix pcmpXstrX instructions in "Equal each" mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Aurelien Jarno pcmpXstrX instructions in "Equal each" mode force both invalid element pair to true. It means (upper - MAX(valids, validd)) bits should be set to 1, not (upper - MAX(valids, validd) + 1). Signed-off-by: Aurelien Jarno --- target-i386/ops_sse.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/ops_sse.h b/target-i386/ops_sse.h index 51c5fc9..2fc5fdd 100644 --- a/target-i386/ops_sse.h +++ b/target-i386/ops_sse.h @@ -2025,7 +2025,7 @@ static inline unsigned pcmpxstrx(CPUX86State *env, Reg *d, Reg *s, } break; case 2: - res = (2 << (upper - MAX(valids, validd))) - 1; + res = (1 << (upper - MAX(valids, validd))) - 1; res <<= MAX(valids, validd) - MIN(valids, validd); for (i = MIN(valids, validd); i >= 0; i--) { res <<= 1; -- 1.7.10.4