Received: from eggs.gnu.org ([208.118.235.92]:36330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPBPr-0006PF-PD for qemu-devel@nongnu.org; Mon, 08 Apr 2013 08:43:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPBPf-0000UU-TD for qemu-devel@nongnu.org; Mon, 08 Apr 2013 08:43:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPBPf-0000UN-Jw for qemu-devel@nongnu.org; Mon, 08 Apr 2013 08:43:07 -0400 From: Stefan Hajnoczi Date: Mon, 8 Apr 2013 14:42:57 +0200 Message-Id: <1365424978-4348-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1365424978-4348-1-git-send-email-stefanha@redhat.com> References: <1365424978-4348-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] vmxnet3: iPXE compatibility fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Dmitry Fleytman , Anthony Liguori , Stefan Hajnoczi , rth@twiddle.net From: Dmitry Fleytman iPXE vmxnet3 driver makes a few assumptions regarding device operation that were missed during testing with Linux and Windows drivers. This patch adds following logic: 1. Additional GET commands processing added 2. Max number of RX chunks should be set to 1 when driver passes 0 via corresponding shared memory field 3. Enforecement for max chunks number added Signed-off-by: Dmitry Fleytman Signed-off-by: Stefan Hajnoczi --- hw/vmxnet3.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/vmxnet3.c b/hw/vmxnet3.c index bdd256e..1e18168 100644 --- a/hw/vmxnet3.c +++ b/hw/vmxnet3.c @@ -1033,6 +1033,7 @@ vmxnet3_indicate_packet(VMXNET3State *s) is_head = false; ready_rxcd_pa = new_rxcd_pa; new_rxcd_pa = 0; + num_frags++; } if (0 != ready_rxcd_pa) { @@ -1324,6 +1325,10 @@ static void vmxnet3_activate_device(VMXNET3State *s) s->max_rx_frags = VMXNET3_READ_DRV_SHARED16(s->drv_shmem, devRead.misc.maxNumRxSG); + if (s->max_rx_frags == 0) { + s->max_rx_frags = 1; + } + VMW_CFPRN("Max RX fragments is %u", s->max_rx_frags); s->event_int_idx = @@ -1524,6 +1529,12 @@ static uint64_t vmxnet3_get_command_status(VMXNET3State *s) VMW_CFPRN("Device active: %" PRIx64, ret); break; + case VMXNET3_CMD_RESET_DEV: + case VMXNET3_CMD_QUIESCE_DEV: + case VMXNET3_CMD_GET_QUEUE_STATUS: + ret = 0; + break; + case VMXNET3_CMD_GET_LINK: ret = s->link_status_and_speed; VMW_CFPRN("Link and speed: %" PRIx64, ret); -- 1.8.1.4