Received: from eggs.gnu.org ([208.118.235.92]:53714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USDm5-0004dL-AD for qemu-devel@nongnu.org; Tue, 16 Apr 2013 17:50:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USDm3-0008B2-RZ for qemu-devel@nongnu.org; Tue, 16 Apr 2013 17:50:49 -0400 Received: from qmta01.emeryville.ca.mail.comcast.net ([2001:558:fe2d:43:76:96:30:16]:34721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USDm3-0008Ap-GE for qemu-devel@nongnu.org; Tue, 16 Apr 2013 17:50:47 -0400 From: Eric Blake Date: Tue, 16 Apr 2013 15:50:41 -0600 Message-Id: <1366149041-626-1-git-send-email-eblake@redhat.com> Subject: [Qemu-devel] [PATCH] migration: reflect incoming failure to shell List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, phrdina@redhat.com, quintela@redhat.com Management apps like libvirt don't know to pay attention to stderr unless there is a non-zero exit status. * migration.c (process_incoming_migration_co): Exit with non-zero status on failure. Signed-off-by: Eric Blake --- Noticed while reviewing: https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03293.html and it seems blatant enough to fix now, rather than waiting for Pavel's series to stabilize. Side note: libvirt explicitly forbids all use of exit({0,1}), and instead encourages exit(EXIT_{SUCCESS,FAILURE}), precisely because it makes it harder to slip in unintentional successful exits. migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration.c b/migration.c index 3b4b467..3eb0fad 100644 --- a/migration.c +++ b/migration.c @@ -99,7 +99,7 @@ static void process_incoming_migration_co(void *opaque) qemu_fclose(f); if (ret < 0) { fprintf(stderr, "load of migration failed\n"); - exit(0); + exit(EXIT_FAILURE); } qemu_announce_self(); DPRINTF("successfully loaded vm state\n"); -- 1.8.1.4