Received: from eggs.gnu.org ([208.118.235.92]:47105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXAdo-0002zV-K7 for qemu-devel@nongnu.org; Tue, 30 Apr 2013 09:30:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXAdm-0007dg-PL for qemu-devel@nongnu.org; Tue, 30 Apr 2013 09:30:44 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40071 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXACH-0006aq-QK for qemu-devel@nongnu.org; Tue, 30 Apr 2013 09:02:17 -0400 From: Alexander Graf Date: Tue, 30 Apr 2013 15:02:16 +0200 Message-Id: <1367326936-28539-1-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PATCH] QOM: Fail casts for unknown types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, aliguori@us.ibm.com, av1474@comtv.ru, dingel@linux.vnet.ibm.com, borntraeger@de.ibm.com When we try to cast an object to an unknown type, fail the cast. Today we would simply run into an assert(). This fixes a bug on qemu-system-s390x for me that gets triggered by the audio code looking for PCI and ISA buses. Signed-off-by: Alexander Graf --- qom/object.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/qom/object.c b/qom/object.c index dd53d24..75e6aac 100644 --- a/qom/object.c +++ b/qom/object.c @@ -453,6 +453,11 @@ ObjectClass *object_class_dynamic_cast(ObjectClass *class, TypeImpl *type = class->type; ObjectClass *ret = NULL; + if (!target_type) { + /* target class type unknown, so fail the cast */ + return NULL; + } + if (type->class->interfaces && type_is_ancestor(target_type, type_interface)) { int found = 0; -- 1.6.0.2