Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E648C433FE for ; Fri, 4 Dec 2020 22:51:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 149EF22C97 for ; Fri, 4 Dec 2020 22:51:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726198AbgLDWvL (ORCPT ); Fri, 4 Dec 2020 17:51:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbgLDWvL (ORCPT ); Fri, 4 Dec 2020 17:51:11 -0500 Received: from smtp-o-1.desy.de (smtp-o-1.desy.de [IPv6:2001:638:700:1038::1:9a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB8E8C0613D1 for ; Fri, 4 Dec 2020 14:50:30 -0800 (PST) Received: from smtp-buf-1.desy.de (smtp-buf-1.desy.de [131.169.56.164]) by smtp-o-1.desy.de (Postfix) with ESMTP id 55F8AE081D for ; Fri, 4 Dec 2020 23:50:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp-o-1.desy.de 55F8AE081D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=desy.de; s=default; t=1607122228; bh=wogYQ4GEi07pFNTte0xGD5q/kw+LRNG4GXLGj/0UFoI=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=gm4EgrqVsRLHMcmUYD5w6gPXMJKMiebXz0ErGfy11od8+ZN5sGOO4b61L2Un5tbaz zS0dHMPEBAWau9VwnGFVCmjE1Z80Q8gCkYZIXoMahsmWEgkmZytxlmhyKdW/xYrr7X UAoQhwuwGL9/Db4aMbKzz6dT8jXDUTO5Yt0zHLPo= Received: from smtp-m-1.desy.de (smtp-m-1.desy.de [131.169.56.129]) by smtp-buf-1.desy.de (Postfix) with ESMTP id 4BF401201E1; Fri, 4 Dec 2020 23:50:28 +0100 (CET) X-Virus-Scanned: amavisd-new at desy.de Received: from z-mbx-2.desy.de (z-mbx-2.desy.de [131.169.55.140]) by smtp-intra-1.desy.de (Postfix) with ESMTP id 230B6C0177; Fri, 4 Dec 2020 23:50:28 +0100 (CET) Date: Fri, 4 Dec 2020 23:50:27 +0100 (CET) From: "Mkrtchyan, Tigran" To: Olga Kornievskaia Cc: schumaker anna , linux-nfs , Anna Schumaker Message-ID: <1368097703.2347355.1607122227971.JavaMail.zimbra@desy.de> In-Reply-To: References: <20201203201841.103294-1-Anna.Schumaker@Netapp.com> <852166252.2305208.1607096860375.JavaMail.zimbra@desy.de> Subject: Re: [PATCH 0/3] NFS: Disable READ_PLUS by default MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.8.15_GA_3980 (ZimbraWebClient - FF83 (Mac)/8.8.15_GA_3980) Thread-Topic: Disable READ_PLUS by default Thread-Index: CVXkTobkLp+LUmxBgVQ7J6y9MaGlng== Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org I agree with Olga, especially that disabling doesn't fixes my issue. Unfortunately I have no idea how kernel's vm works, but I am ready to test as many times as needed. Thanks, Tigran. ----- Original Message ----- > From: "Olga Kornievskaia" > To: "Tigran Mkrtchyan" > Cc: "schumaker anna" , "linux-nfs" , "Anna Schumaker" > > Sent: Friday, 4 December, 2020 21:00:32 > Subject: Re: [PATCH 0/3] NFS: Disable READ_PLUS by default > I object to putting the disable patch in, I think we need to fix the problem. > > The current problem is generic/263 is failing because the end of the > buffer is corrupted since we lost the bytes when hole was expanded. I > don't know what the solution is: (1) hole expanding handling needs to > be fixed to not lose data or (2) we shouldnt be reporting that we read > the bytes we lost. > > On Fri, Dec 4, 2020 at 10:49 AM Mkrtchyan, Tigran > wrote: >> >> Hi Anna, >> >> I see problems with gedeviceinfo and bisected it to >> c567552612ece787b178e3b147b5854ad422a836. >> The commit itself doesn't look that can break it, but might >> be can help you find the problem. >> >> What I see, that after xdr_read_pages call the xdr stream points >> to a some random point (or wrong page) >> >> Regards, >> Tigran. >> >> >> ----- Original Message ----- >> > From: "schumaker anna" >> > To: "linux-nfs" >> > Cc: "Anna Schumaker" >> > Sent: Thursday, 3 December, 2020 21:18:38 >> > Subject: [PATCH 0/3] NFS: Disable READ_PLUS by default >> >> > From: Anna Schumaker >> > >> > I've been scratching my head about what's going on with xfstests generic/091 >> > and generic/263, but I'm not sure what else to look at at this point. >> > This patchset disables READ_PLUS by default by marking it as a >> > developer-only kconfig option. >> > >> > I also included a couple of patches fixing some other issues that were >> > noticed while inspecting the code. These patches don't help the tests >> > pass, but they do fail later on after applying so it does feel like >> > progress. >> > >> > I'm hopeful the remaning issues can be worked out in the future. >> > >> > Thanks, >> > Anna >> > >> > >> > Anna Schumaker (3): >> > NFS: Disable READ_PLUS by default >> > NFS: Allocate a scratch page for READ_PLUS >> > SUNRPC: Keep buf->len in sync with xdr->nwords when expanding holes >> > >> > fs/nfs/Kconfig | 9 +++++++++ >> > fs/nfs/nfs42xdr.c | 2 ++ >> > fs/nfs/nfs4proc.c | 2 +- >> > fs/nfs/read.c | 13 +++++++++++-- >> > include/linux/nfs_xdr.h | 1 + >> > net/sunrpc/xdr.c | 3 ++- >> > 6 files changed, 26 insertions(+), 4 deletions(-) >> > >> > -- > > > 2.29.2