From: Scott Wood Subject: Re: [v2][KVM][PATCH 1/1] kvm:ppc: enable doorbell exception with CONFIG_PPC_DOORBELL Date: Fri, 10 May 2013 13:17:08 -0500 Message-ID: <1368209828.19683.5@snotra> References: <1367922232-22455-1-git-send-email-tiejun.chen@windriver.com> <39FBAAD3-4B13-4CA3-9E80-B73A266C1D3A@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed Content-Transfer-Encoding: 8BIT Cc: Tiejun Chen , , , To: Alexander Graf Return-path: In-Reply-To: <39FBAAD3-4B13-4CA3-9E80-B73A266C1D3A@suse.de> (from agraf@suse.de on Fri May 10 13:14:27 2013) Content-Disposition: inline Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 05/10/2013 01:14:27 PM, Alexander Graf wrote: > > On 07.05.2013, at 12:23, Tiejun Chen wrote: > > > CONFIG_PPC_DOORBELL is enough to cover all variants. > > > > Signed-off-by: Tiejun Chen > > --- > > arch/powerpc/kvm/booke.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c > > index 1020119..62d4ece 100644 > > --- a/arch/powerpc/kvm/booke.c > > +++ b/arch/powerpc/kvm/booke.c > > @@ -795,7 +795,7 @@ static void kvmppc_restart_interrupt(struct > kvm_vcpu *vcpu, > > kvmppc_fill_pt_regs(®s); > > timer_interrupt(®s); > > break; > > -#if defined(CONFIG_PPC_FSL_BOOK3E) || defined(CONFIG_PPC_BOOK3E_64) > > +#if defined(CONFIG_PPC_DOORBELL) > > The same question still holds. How is this an improvement over the > previous code? Does this fix any issues for you? Is this just a > coding style cleanup? This is an improvement because CONFIG_PPC_DOORBELL is what controls whether the function that is called inside the ifdef exists. -Scott