From: Jaegeuk Kim Subject: Re: [PATCH][Trivial] f2fs: Use list_for_each_entry rather than list_for_each_entry_safe. Date: Wed, 15 May 2013 13:45:36 +0900 Message-ID: <1368593136.11843.17.camel@kjgkr> References: <519228D6.4070504@gmail.com> Reply-To: jaegeuk.kim@samsung.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-J/izR7Wp+U4lsVyaCtco" Cc: linux-fsdevel , linux-f2fs-devel@lists.sourceforge.net To: majianpeng Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:20334 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753886Ab3EOEqq (ORCPT ); Wed, 15 May 2013 00:46:46 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMT006KKP9V6GM0@mailout4.samsung.com> for linux-fsdevel@vger.kernel.org; Wed, 15 May 2013 13:46:43 +0900 (KST) In-reply-to: <519228D6.4070504@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: --=-J/izR7Wp+U4lsVyaCtco Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Jianpeng, Could you explain why this *should* be changed? Thanks, 2013-05-14 (=ED=99=94), 20:06 +0800, majianpeng: > Signed-off-by: Jianpeng Ma > --- > fs/f2fs/debug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c > index 8d99437..0d6c6aa 100644 > --- a/fs/f2fs/debug.c > +++ b/fs/f2fs/debug.c > @@ -175,12 +175,12 @@ get_cache: > =20 > static int stat_show(struct seq_file *s, void *v) > { > - struct f2fs_stat_info *si, *next; > + struct f2fs_stat_info *si; > int i =3D 0; > int j; > =20 > mutex_lock(&f2fs_stat_mutex); > - list_for_each_entry_safe(si, next, &f2fs_stat_list, stat_list) { > + list_for_each_entry(si, &f2fs_stat_list, stat_list) { > char devname[BDEVNAME_SIZE]; > =20 > update_general_status(si->sbi); --=20 Jaegeuk Kim Samsung --=-J/izR7Wp+U4lsVyaCtco Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAABAgAGBQJRkxLwAAoJEEAUqH6CSFDSpaUP/i0PkNy9iTjqiyw7X7alLJ05 uWim4SMwN/RiQ/mex+08r0SUjTbBwCcYLKubQVe7X/wSnDhsa9+hcOSOGA17rE6i 9OyFUMfCAMMKaOjB5QPeH1JHRmnReGaZDXXZcJvU1nbLEyJLBsGz1TIunweNSg9F LeujJ5EMHw1T3b7nDSAI4OdNLQ2f7/XVK/yGrg1fIwsGW0f+pPgAmp6KZNTkGyG8 MlItIfZbfEaMcZXnB2HVL3ytDVhtQrYNEjWybhOWCU73KvHqeJJdYKoL98CBWbuu m3sB7t6FUT80wZJjbTu3XX/E5neqrJ7eFnCdSt7cS2/4idwMK2DbfEGv9NZqdRDS W0HlqjCKDzgJlPu7Vr2++jw3vA6peIDcBr2ObGnmoY8ei6JFJlbYMDb8dqhYDJ3e ByHEpgNi3gGWE/zhMYvsBlujzhPrHHe/A8g8k+NhhaRj5dEPtl0jq7sNw1KGo+du 5HeLsyo5hBqaATGqJkrIdNaXDwV2yE0k0BcCZL8uSY+cB8FhC0xpXAALq57vQie/ P8GeK0BnrjytTDI2ZqOojJTugzqRZt9LZZujAY8OrTS9s3eOidxJZcQ1svBy6jXy L1PCkHcnnansEbmkPFtl81HIXmpdXpeydU8YFDtuK61bNVqQNpaKp4/j6pSjOIkP r8nnLJnxvim5Y7ADOduG =Oj63 -----END PGP SIGNATURE----- --=-J/izR7Wp+U4lsVyaCtco--