From: Michel =?ISO-8859-1?Q?D=E4nzer?= Subject: Re: [PATCH] drm: fix a use-after-free when GPU acceleration disabled Date: Tue, 21 May 2013 09:59:32 +0200 Message-ID: <1369123172.19642.9.camel@thor.local> References: <1369117423-7772-1-git-send-email-chenhc@lemote.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E936E5EFE for ; Tue, 21 May 2013 00:59:48 -0700 (PDT) In-Reply-To: <1369117423-7772-1-git-send-email-chenhc@lemote.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Huacai Chen Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRGllLCAyMDEzLTA1LTIxIGF0IDE0OjIzICswODAwLCBIdWFjYWkgQ2hlbiB3cm90ZToKPiBX aGVuIEdQVSBhY2NlbGVyYXRpb24gaXMgZGlzYWJsZWQsIGRybV92YmxhbmtfY2xlYW51cCgpIHdp bGwgZnJlZSB0aGUKPiB2YmxhbmstcmVsYXRlZCBkYXRhLCBzdWNoIGFzIHZibGFua19yZWZjb3Vu dCwgdmJsYW5rX2lubW9kZXNldCwgZXRjLgo+IEJ1dCB3ZSBmb3VuZCB0aGF0IGRybV92Ymxhbmtf cG9zdF9tb2Rlc2V0KCkgbWF5IGJlIGNhbGxlZCBhZnRlciB0aGUKPiBjbGVhbnVwLCB3aGljaCB1 c2UgdmJsYW5rX3JlZmNvdW50IGFuZCB2YmxhbmtfaW5tb2Rlc2V0LiBBbmQgdGhpcyB3aWxsCj4g Y2F1c2UgYSBrZXJuZWwgcGFuaWMuCj4gCj4gRml4IHRoaXMgYnkgcmV0dXJuIGltbWVkaWF0ZWx5 IGlmIGRldi0+bnVtX2NydGNzIGlzIHplcm8uIFRoaXMgaXMgdGhlCj4gc2FtZSB0aGluZyB0aGF0 IGRybV92YmxhbmtfcHJlX21vZGVzZXQoKSBkb2VzLgo+IAo+IENhbGwgdHJhY2Ugb2YgYSBkcm1f dmJsYW5rX3Bvc3RfbW9kZXNldCgpIGFmdGVyIGRybV92YmxhbmtfY2xlYW51cCgpOgo+IFsgICA2 Mi42Mjg5MDZdIFs8ZmZmZmZmZmY4MDQ4NjhkMD5dIGRybV92YmxhbmtfcG9zdF9tb2Rlc2V0KzB4 MzQvMHhiNAo+IFsgICA2Mi42Mjg5MDZdIFs8ZmZmZmZmZmY4MDRjNzAwOD5dIGF0b21iaW9zX2Ny dGNfZHBtcysweGI0LzB4MTc0Cj4gWyAgIDYyLjYyODkwNl0gWzxmZmZmZmZmZjgwNGM3MGUwPl0g YXRvbWJpb3NfY3J0Y19jb21taXQrMHgxOC8weDM4Cj4gWyAgIDYyLjYyODkwNl0gWzxmZmZmZmZm ZjgwNDdmMDM4Pl0gZHJtX2NydGNfaGVscGVyX3NldF9tb2RlKzB4MzA0LzB4M2NjCj4gWyAgIDYy LjYyODkwNl0gWzxmZmZmZmZmZjgwNDdmOTJjPl0gZHJtX2NydGNfaGVscGVyX3NldF9jb25maWcr MHg2ZDgvMHg5ODgKPiBbICAgNjIuNjI4OTA2XSBbPGZmZmZmZmZmODA0N2RkNDA+XSBkcm1fZmJf aGVscGVyX3NldF9wYXIrMHg5NC8weDEwNAo+IFsgICA2Mi42Mjg5MDZdIFs8ZmZmZmZmZmY4MDQz OWQxND5dIGZiY29uX2luaXQrMHg0MjQvMHg1N2MKPiBbICAgNjIuNjI4OTA2XSBbPGZmZmZmZmZm ODA0NmE2Mzg+XSB2aXN1YWxfaW5pdCsweGI4LzB4MTE4Cj4gWyAgIDYyLjYyODkwNl0gWzxmZmZm ZmZmZjgwNDZiOWY4Pl0gdGFrZV9vdmVyX2NvbnNvbGUrMHgyMzgvMHgzODQKPiBbICAgNjIuNjI4 OTA2XSBbPGZmZmZmZmZmODA0MzZkZjg+XSBmYmNvbl90YWtlb3ZlcisweDdjLzB4ZGMKPiBbICAg NjIuNjI4OTA2XSBbPGZmZmZmZmZmODAyNGZhMjA+XSBub3RpZmllcl9jYWxsX2NoYWluKzB4NDQv MHg5NAo+IFsgICA2Mi42Mjg5MDZdIFs8ZmZmZmZmZmY4MDI0ZmNiYz5dIF9fYmxvY2tpbmdfbm90 aWZpZXJfY2FsbF9jaGFpbisweDQ4LzB4NjgKPiBbICAgNjIuNjI4OTA2XSBbPGZmZmZmZmZmODA0 MmQ5OTA+XSByZWdpc3Rlcl9mcmFtZWJ1ZmZlcisweDIyOC8weDI2MAo+IFsgICA2Mi42Mjg5MDZd IFs8ZmZmZmZmZmY4MDQ3ZTAxMD5dIGRybV9mYl9oZWxwZXJfc2luZ2xlX2ZiX3Byb2JlKzB4MjYw LzB4MzE0Cj4gWyAgIDYyLjYyODkwNl0gWzxmZmZmZmZmZjgwNDdlMmM0Pl0gZHJtX2ZiX2hlbHBl cl9pbml0aWFsX2NvbmZpZysweDIwMC8weDIzNAo+IFsgICA2Mi42Mjg5MDZdIFs8ZmZmZmZmZmY4 MDRlNTU2MD5dIHJhZGVvbl9mYmRldl9pbml0KzB4ZDQvMHhmNAo+IFsgICA2Mi42Mjg5MDZdIFs8 ZmZmZmZmZmY4MDRlMGUwOD5dIHJhZGVvbl9tb2Rlc2V0X2luaXQrMHg5YmMvMHhhMTgKPiBbICAg NjIuNjI4OTA2XSBbPGZmZmZmZmZmODA0YmZjMTQ+XSByYWRlb25fZHJpdmVyX2xvYWRfa21zKzB4 ZGMvMHgxMmMKPiBbICAgNjIuNjI4OTA2XSBbPGZmZmZmZmZmODA0OGI1NDg+XSBkcm1fZ2V0X3Bj aV9kZXYrMHgxNDgvMHgyMzgKPiBbICAgNjIuNjI4OTA2XSBbPGZmZmZmZmZmODA0MjM1NjQ+XSBs b2NhbF9wY2lfcHJvYmUrMHg1Yy8weGQwCj4gWyAgIDYyLjYyODkwNl0gWzxmZmZmZmZmZjgwMjQx YWM0Pl0gd29ya19mb3JfY3B1X2ZuKzB4MWMvMHgzMAo+IFsgICA2Mi42Mjg5MDZdIFs8ZmZmZmZm ZmY4MDI0MjdjOD5dIHByb2Nlc3Nfb25lX3dvcmsrMHgyNzQvMHgzYmMKPiBbICAgNjIuNjI4OTA2 XSBbPGZmZmZmZmZmODAyNDI5MzQ+XSBwcm9jZXNzX3NjaGVkdWxlZF93b3JrcysweDI0LzB4NDQK PiBbICAgNjIuNjI4OTA2XSBbPGZmZmZmZmZmODAyNDUxNWM+XSB3b3JrZXJfdGhyZWFkKzB4MzFj LzB4M2Y0Cj4gWyAgIDYyLjYyODkwNl0gWzxmZmZmZmZmZjgwMjQ5N2E4Pl0ga3RocmVhZCsweDg4 LzB4OTAKPiBbICAgNjIuNjI4OTA2XSBbPGZmZmZmZmZmODAyMDY3OTQ+XSBrZXJuZWxfdGhyZWFk X2hlbHBlcisweDEwLzB4MTgKPiAKPiBTaWduZWQtb2ZmLWJ5OiBIdWFjYWkgQ2hlbiA8Y2hlbmhj QGxlbW90ZS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogQmluYmluIFpob3UgPHpob3ViYkBsZW1vdGUu Y29tPgo+IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2RybV9pcnEuYyB8ICAgIDYgKysrKystCj4gIDEgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRp b25zKCspLCAxIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX2lycS5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9pcnEuYwo+IGluZGV4IGM3OThlZWEuLmM3 YTEzNDggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9pcnEuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1faXJxLmMKPiBAQCAtOTgxLDcgKzk4MSw3IEBAIEVYUE9SVF9TWU1C T0woZHJtX3ZibGFua19vZmYpOwo+ICAgKi8KPiAgdm9pZCBkcm1fdmJsYW5rX3ByZV9tb2Rlc2V0 KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGludCBjcnRjKQo+ICB7Cj4gLSAgICAgICAvKiB2Ymxh bmsgaXMgbm90IGluaXRpYWxpemVkIChJUlEgbm90IGluc3RhbGxlZCA/KSAqLwo+ICsgICAgICAg LyogdmJsYW5rIGlzIG5vdCBpbml0aWFsaXplZCAoSVJRIG5vdCBpbnN0YWxsZWQgPyksIG9yIGhh cyBiZWVuIGZyZWVkICovCj4gICAgICAgICBpZiAoIWRldi0+bnVtX2NydGNzKQo+ICAgICAgICAg ICAgICAgICByZXR1cm47Cj4gICAgICAgICAvKgo+IEBAIC0xMDAzLDYgKzEwMDMsMTAgQEAgdm9p ZCBkcm1fdmJsYW5rX3Bvc3RfbW9kZXNldChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBpbnQgY3J0 YykKPiAgewo+ICAgICAgICAgdW5zaWduZWQgbG9uZyBpcnFmbGFnczsKPiAgCj4gKyAgICAgICAv KiB2YmxhbmsgaXMgbm90IGluaXRpYWxpemVkIChJUlEgbm90IGluc3RhbGxlZCA/KSwgb3IgaGFz IGJlZW4gZnJlZWQgKi8KPiArICAgICAgIGlmICghZGV2LT5udW1fY3J0Y3MpCj4gKyAgICAgICAg ICAgICAgIHJldHVybjsKPiArCj4gICAgICAgICBpZiAoZGV2LT52YmxhbmtfaW5tb2Rlc2V0W2Ny dGNdKSB7Cj4gICAgICAgICAgICAgICAgIHNwaW5fbG9ja19pcnFzYXZlKCZkZXYtPnZibF9sb2Nr LCBpcnFmbGFncyk7Cj4gICAgICAgICAgICAgICAgIGRldi0+dmJsYW5rX2Rpc2FibGVfYWxsb3dl ZCA9IDE7CgpUaGUgY29tbWVudCBjaGFuZ2VzIHNlZW0gc3VwZXJmbHVvdXMgdG8gbWUsIGJ1dCBl aXRoZXIgd2F5OgoKUmV2aWV3ZWQtYnk6IE1pY2hlbCBEw6RuemVyIDxtaWNoZWwuZGFlbnplckBh bWQuY29tPgoKCi0tIApFYXJ0aGxpbmcgTWljaGVsIETDpG56ZXIgICAgICAgICAgIHwgICAgICAg ICAgICAgICAgICAgaHR0cDovL3d3dy5hbWQuY29tCkxpYnJlIHNvZnR3YXJlIGVudGh1c2lhc3Qg ICAgICAgICB8ICAgICAgICAgIERlYmlhbiwgWCBhbmQgRFJJIGRldmVsb3BlcgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=