Received: from eggs.gnu.org ([208.118.235.92]:57491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhDU5-0007gH-PX for qemu-devel@nongnu.org; Tue, 28 May 2013 02:34:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhDU0-0006qI-V2 for qemu-devel@nongnu.org; Tue, 28 May 2013 02:34:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhDU0-0006q1-Nm for qemu-devel@nongnu.org; Tue, 28 May 2013 02:34:08 -0400 From: Gerd Hoffmann Date: Tue, 28 May 2013 08:34:03 +0200 Message-Id: <1369722844-24345-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1369722844-24345-1-git-send-email-kraxel@redhat.com> References: <1369722844-24345-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] chardev: fix "info chardev" output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Gerd Hoffmann , stefano.stabellini@eu.citrix.com Fill unset CharDriverState->filename with the backend name, so 'info chardev' will return at least the chardev type. Don't touch it in case the chardev init function filled it already, like the socket+pty chardevs do for example. Signed-off-by: Gerd Hoffmann --- qemu-char.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index f825294..d04b429 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3801,6 +3801,9 @@ ChardevReturn *qmp_chardev_add(const char *id, ChardevBackend *backend, chr->label = g_strdup(id); chr->avail_connections = (backend->kind == CHARDEV_BACKEND_KIND_MUX) ? MAX_MUX : 1; + if (!chr->filename) { + chr->filename = g_strdup(ChardevBackendKind_lookup[backend->kind]); + } QTAILQ_INSERT_TAIL(&chardevs, chr, next); return ret; } else { -- 1.7.9.7