Return-Path: From: Johan Hovold To: Greg KH Cc: Anders Hammarquist , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Johan Hovold , stable Subject: [PATCH] USB: ti_usb_3410_5052: fix dynamic-id matching Date: Fri, 28 Jun 2013 12:24:26 +0200 Message-Id: <1372415066-1031-1-git-send-email-jhovold@gmail.com> In-Reply-To: <20130628102333.GA13241@localhost> References: <20130628102333.GA13241@localhost> Sender: linux-kernel-owner@vger.kernel.org List-ID: The driver failed to take the dynamic ids into account when determining the device type and therefore all devices were detected as 2-port devices when using the dynamic-id interface. Match on the usb-serial-driver field instead of doing redundant id-table searches. Reported-by: Anders Hammarquist Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/ti_usb_3410_5052.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c index 5585b20..5c07d55 100644 --- a/drivers/usb/serial/ti_usb_3410_5052.c +++ b/drivers/usb/serial/ti_usb_3410_5052.c @@ -309,7 +309,7 @@ static int ti_startup(struct usb_serial *serial) usb_set_serial_data(serial, tdev); /* determine device type */ - if (usb_match_id(serial->interface, ti_id_table_3410)) + if (serial->type == &ti_1port_device) tdev->td_is_3410 = 1; dev_dbg(&dev->dev, "%s - device type is %s\n", __func__, tdev->td_is_3410 ? "3410" : "5052"); -- 1.8.2.1