From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Subject: Re: [PATCH] f2fs: make sanity_check_ckpt more strict
Date: Tue, 02 Jul 2013 08:23:37 +0900
Message-ID: <1372721017.736.11.camel@kjgkr>
References: <51CDAA82.40401@gmail.com>
Reply-To: jaegeuk.kim@samsung.com
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: linux-fsdevel@vger.kernel.org
To: Wang Sheng-Hui <shhuiw@gmail.com>
In-reply-to: <51CDAA82.40401@gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org

Hi,

2013-06-28 (=EA=B8=88), 23:23 +0800, Wang Sheng-Hui:
> In mkfs, we have check:
>      if ((le32_to_cpu(super_block.segment_count_main) - 2) <
>          config.reserved_segments) {

This is not the sanity check flow.
It's just to check whether the volume size is enoughly large or not.

>=20
> In super.c/sanity_check_ckpt, we should make the check as strict
> as mkfs.

> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
>   fs/f2fs/super.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 8555f7d..b64f38a 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -448,7 +448,7 @@ static int sanity_check_ckpt(struct f2fs_sb_info =
*sbi)
>   	fsmeta =3D le32_to_cpu(raw_super->segment_count_ckpt);
>   	fsmeta +=3D le32_to_cpu(raw_super->segment_count_sit);
>   	fsmeta +=3D le32_to_cpu(raw_super->segment_count_nat);
> -	fsmeta +=3D le32_to_cpu(ckpt->rsvd_segment_count);
> +	fsmeta +=3D le32_to_cpu(ckpt->rsvd_segment_count) + 2;

NAK.
The fsmeta is used to check whether total segment count is matched to
the sum of each area's segment counts.
Thanks,


--=20
Jaegeuk Kim
Samsung

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel=
" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html